Closed
Bug 1437926
Opened 6 years ago
Closed 6 years ago
[MIPS64] Fix MacroAssembler::unboxPrivate
Categories
(Core :: JavaScript Engine: JIT, enhancement, P5)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
Details
Attachments
(1 file)
|
969 bytes,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36
|
Assignee | |
Comment 1•6 years ago
|
||
Previous implementation erroneously used right logical shift instead of left shift.
Attachment #8950620 -
Flags: review?(bbouvier)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8950620 [details] [diff] [review] bug1437926.patch Review of attachment 8950620 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thanks!
Attachment #8950620 -
Flags: review?(bbouvier) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Updated•6 years ago
|
status-firefox60:
--- → fix-optional
Priority: -- → P5
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a51ff0f45a [MIPS64] Fix MacroAssembler::unboxPrivate; r=bbouvier
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d9a51ff0f45a
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Assignee: nobody → dragan.mladjenovic
You need to log in
before you can comment on or make changes to this bug.
Description
•