1437938 - Remove unused /jobs/update_state/ API

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, enhancement, P1)

Description

[Ed Morley [:emorley]]

New Relic says `JobsViewSet.update_state` hasn't been accessed once in the last 7 days:
https://rpm.newrelic.com/accounts/677903/applications/14179757/transactions/table?type=app

The remaining REST API job submitters are instead using the `JobsViewSet.create` method to transition a job from one state to the next. Which makes sense, since more properties than just the state need changing (eg start_time, end_time), which means the `update_state` method is never sufficient on its own.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3221

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8950639 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3221

Papertrail confirms the New Relic finding of no requests made:
https://papertrailapp.com/systems/treeherder-prod/events?q=update_state

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2eac7bcea42868626fe0bb653b2b0a4003af6e8f
Bug 1437938 - Remove unused /jobs/update_state/ API (#3221)

The remaining REST API job submitters are using `JobsViewSet.create`
to transition jobs from one state to the next instead.