Closed Bug 1437940 Opened 6 years ago Closed 6 years ago

Firefox does not detect that I have Chrome Dev (Unstable) or Beta installed on Ubuntu

Categories

(Firefox :: Migration, defect, P3)

Product:
Firefox
Component:
Migration
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- verified

People

(Reporter: pascalc, Assigned: Gijs)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux,
59 bytes, text/x-review-board-request
alexical
: review+
Details
Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data,
59 bytes, text/x-review-board-request
alexical
: review+
Details 
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 ID:20180212220112 Ubuntu 17.10

(I also have the same bug with the distro-provided Firefox version, release channel)

STR:
1 Open the bookmarks management window
2 Select Import Data from Another Browser… in the top menu

ER:
Get proposed to import Chrome data (I have both Chromium and Chrome Dev installed)

AR:
I only get Chromium 64 listed, not Chrome Dev 66 that I installed with https://www.google.com/chrome/?platform=linux&extra=devchannel
This sounds like it is Linux or distro-specific. Can you find your Chrome profile path and post it here?
Flags: needinfo?(pascalc)
OS: Unspecified → Linux
Priority: -- → P3
Summary: Firefox does not detect that I have Chrome installed → Firefox does not detect that I have Chrome installed on Ubuntu
(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #1)
> This sounds like it is Linux or distro-specific. Can you find your Chrome
> profile path and post it here?


/usr/bin/google-chrome-unstable -> /opt/google/chrome-unstable/google-chrome-unstable
Flags: needinfo?(pascalc)
(In reply to Pascal Chevrel:pascalc from comment #2)
> (In reply to Matthew N. [:MattN] (PM if requests are blocking you) from
> comment #1)
> > This sounds like it is Linux or distro-specific. Can you find your Chrome
> > profile path and post it here?
> 
> 
> /usr/bin/google-chrome-unstable ->
> /opt/google/chrome-unstable/google-chrome-unstable

That's the binary path, not the profile path.
Flags: needinfo?(pascalc)
(specifically, by default we look under $HOME/.config/{google-chrome,chromium} - presumably in your case the data is somewhere else)
(In reply to :Gijs from comment #4)
> (specifically, by default we look under
> $HOME/.config/{google-chrome,chromium} - presumably in your case the data is
> somewhere else)

Sorry, I misread and thought you wanted the binary path. Here is the profile path:
$HOME/.config/google-chrome-unstable/Default
Flags: needinfo?(pascalc)
(In reply to Pascal Chevrel:pascalc from comment #5)
> (In reply to :Gijs from comment #4)
> > (specifically, by default we look under
> > $HOME/.config/{google-chrome,chromium} - presumably in your case the data is
> > somewhere else)
> 
> Sorry, I misread and thought you wanted the binary path. Here is the profile
> path:
> $HOME/.config/google-chrome-unstable/Default

What is "google chrome unstable" ? https://www.chromium.org/getting-involved/dev-channel lists release, beta, dev and canary. I don't understand what 'unstable' is and where it comes from.
Flags: needinfo?(pascalc)
(In reply to :Gijs from comment #6)
> (In reply to Pascal Chevrel:pascalc from comment #5)
> > (In reply to :Gijs from comment #4)
> > > (specifically, by default we look under
> > > $HOME/.config/{google-chrome,chromium} - presumably in your case the data is
> > > somewhere else)
> > 
> > Sorry, I misread and thought you wanted the binary path. Here is the profile
> > path:
> > $HOME/.config/google-chrome-unstable/Default
> 
> What is "google chrome unstable" ?
> https://www.chromium.org/getting-involved/dev-channel lists release, beta,
> dev and canary. I don't understand what 'unstable' is and where it comes
> from.

Huh, looks like the Google Chrome PPA has its own names for things, and this is equivalent to 'dev'. This is additionally odd because at least according to the docs I linked, the data for release, beta and dev is in the same place on Windows and mac - only Canary gets its own folder... I wonder if the docs are wrong. :-\
Flags: needinfo?(pascalc)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Gah, it also seems we have regressed some stuff in bug 1410839 in terms of where we look for profile lists for non-release versions of Chrome. Fixing that while we're here.

Separately, it seems Chrome's cookie database format has changed so cookie imports are failing. I don't know off-hand when that happened or what exactly has changed, but I get errors saying there's no column 'secure'. If I remove that column from the select, there's no column 'httponly'. It's not really relevant to this bug so I won't try and fix this here, but I'll file a follow-up and we should probably investigate that further separately.
Depends on: 1442271
Comment on attachment 8955159 [details]
Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data,

https://reviewboard.mozilla.org/r/224334/#review230286

::: browser/components/migration/ChromeMigrationUtils.jsm
(Diff revision 1)
>  ChromeUtils.import("resource://gre/modules/osfile.jsm");
>  ChromeUtils.import("resource://gre/modules/Services.jsm");
>  ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
>  
>  var ChromeMigrationUtils = {
> -  _chromeUserDataPath: null,

Hm, outright removing the caching here may make some of the extension APIs slow, because we'll do the lookups repeatedly because of how the various APIs are nested and don't pass some of the info. I don't know if we're using these at this point (I don't *think* so, but perhaps this only happens in experiments or something). Doug, do you know more about this? Feel free to r- if this is a serious concern at this point.
Summary: Firefox does not detect that I have Chrome installed on Ubuntu → Firefox does not detect that I have Chrome Dev (Unstable) or Beta installed on Ubuntu
Comment on attachment 8955121 [details]
Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux,

https://reviewboard.mozilla.org/r/224278/#review230328

::: browser/components/migration/ChromeProfileMigrator.js:499
(Diff revision 3)
> +if (AppConstants.platform != "win" && AppConstants.platform != "macosx") {
> +  function ChromeDevMigrator() {
> +    this._chromeUserDataPathSuffix = "Chrome Dev";
> +  }
> +  ChromeDevMigrator.prototype = Object.create(ChromeProfileMigrator.prototype);
> +  ChromeDevMigrator.prototype.classDescription = "Chrome Unstable Profile Migrator";

Nit: should this be "Chrome Dev Profile Migrator", since "unstable" is only used for the path in the rest of the patch?
Attachment #8955121 - Flags: review?(dothayer) → review+
Comment on attachment 8955159 [details]
Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data,

https://reviewboard.mozilla.org/r/224334/#review230332
Attachment #8955159 - Flags: review?(dothayer) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/97f62d602644
include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
https://hg.mozilla.org/integration/autoland/rev/055e1339d5e9
fix where we look for a 'Local State' file for non-release Chrome data, r=dthayer
Flags: qe-verify+
I was able to reproduce the issue on Linux 14.04 x86_x64 using Fx60.0a1 (build ID: 20180213100127). The broswer only detects Chrome, even though Chromium is installed as well.
Tested on the same OS using Fx60.0b5 and Fx61.0a1. Both Fx versions detect Chrome and Chromium in the 'Import Settings and Data' window.
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified
Flags: qe-verify+
Depends on: 1591992
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: