1437955 - Remove ParseNodeKind::Semi and Nop

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jason Orendorff [:jorendorff]]

"What kind of parse node is it?"

"It's a nop"

TypeError

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1: Split ParseNodeKind::Semi into ExpressionStatement and EmptyStatement

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2: Remove unused ParseNodeKind::Nop

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8950656 [details] [diff] [review]
Part 1: Split ParseNodeKind::Semi into ExpressionStatement and EmptyStatement

Review of attachment 8950656 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/wasm/AsmJS.cpp
@@ +7160,5 @@
> +      case ParseNodeKind::Return:               return CheckReturn(f, stmt);
> +      case ParseNodeKind::StatementList:        return CheckStatementList(f, stmt);
> +      case ParseNodeKind::Break:                return CheckBreakOrContinue(f, true, stmt);
> +      case ParseNodeKind::Continue:             return CheckBreakOrContinue(f, false, stmt);
> +      case ParseNodeKind::LexicalScope:         return CheckLexicalScope(f, stmt);

If you're touching all these lines, could I possibly trouble you to undo the single-lineness here?  Case on one line, subsequent return statement on the next, blank line between implied case-blocks.  Horizontal alignment of things after other things is just dumb and not worth the trouble.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Part 0: Fix places where bug 1429206 left old filenames in comments

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 8951647 [details] [diff] [review]
Part 0: Fix places where bug 1429206 left old filenames in comments

Review of attachment 8951647 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

Comment 6

[Jason Orendorff [:jorendorff]]

Oh no, that patch is in the wrong bug. Derp.

Comment 7

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5af2048781f79275389f390cc922080407d4342

Comment 8

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e21126825c41be2a70bb6759e2dbdc7190621608
Bug 1437955 - Part 1: Split ParseNodeKind::Semi into ExpressionStatement and EmptyStatement. r=Waldo.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b593a217bb5a4bd160dff15f1fc1577b95f06778
Bug 1437955 - Part 2: Remove unused ParseNodeKind::Nop. r=Waldo.

Comment 9

[Jason Orendorff [:jorendorff]]

(The right bug for "Part 0" is bug 1438278.)

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e21126825c41
https://hg.mozilla.org/mozilla-central/rev/b593a217bb5a