Closed
Bug 1437995
Opened 6 years ago
Closed 6 years ago
test262 feature check for BigInt
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: terpri, Assigned: terpri)
References
Details
Attachments
(1 file, 2 obsolete files)
724.19 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Add a feature check for BigInt to test262-update.py.
Assignee | ||
Updated•6 years ago
|
Attachment #8950704 -
Flags: review?(andrebargull)
Updated•6 years ago
|
Assignee: nobody → robin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 1•6 years ago
|
||
This change will only modify the |reftest| marker when test262 is updated the next time, but I guess you also wanted to enable BigInt tests for the currently checked out version of test262, right? For that you need to run the "test262-update.py" script in js/src/tests: --- cd js/src/tests ./test262-update.py --revision=82c6148980332febe92a544a1fb653718e9fdb57 --- This will modify the current "skip" annotation [1] with "skip-if(!this.hasOwnProperty('BigInt'))". (The git revision of the currently checked out version of test262 is saved in [2].) [1] https://searchfox.org/mozilla-central/rev/d03ad8843e3bf2e856126bc53b0475c595e5183b/js/src/tests/test262/built-ins/BigInt/asIntN/arithmetic.js#1 [2] https://searchfox.org/mozilla-central/source/js/src/tests/test262/GIT-INFO
Flags: needinfo?(robin)
Assignee | ||
Comment 2•6 years ago
|
||
include regenerated tests with BigInt feature check
Attachment #8950704 -
Attachment is obsolete: true
Attachment #8950704 -
Flags: review?(andrebargull)
Flags: needinfo?(robin)
Attachment #8951413 -
Flags: review?(andrebargull)
Comment 3•6 years ago
|
||
Comment on attachment 8951413 [details] [diff] [review] bigint-feature-check.diff Review of attachment 8951413 [details] [diff] [review]: ----------------------------------------------------------------- I've skimmed over the changes and didn't see any obvious issues, so rs=me. Thanks for the patch!
Attachment #8951413 -
Flags: review?(andrebargull) → review+
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•6 years ago
|
||
rebase and regenerate tests with currently-used test262 revision
Attachment #8951413 -
Attachment is obsolete: true
Attachment #8968263 -
Flags: checkin?(jorendorff)
Updated•6 years ago
|
Attachment #8968263 -
Flags: checkin?(jorendorff) → review+
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/135f00f02937 "test262 feature check for BigInt" r=jorendorff
Keywords: checkin-needed
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/135f00f02937
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•