Closed Bug 1437998 Opened 2 years ago Closed 2 years ago

4,900 instances of "Unable to find interface object on global" emitted from dom/base/nsDOMClassInfo.cpp during linux64 debug testing

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: erahm, Assigned: bholley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 4940 WARNING: Unable to find interface object on global: file dom/base/nsDOMClassInfo.cpp, line 1746

This warning [1] shows up in the following test suites:

>    724 - test-linux64/debug-mochitest-e10s-13 13
>    722 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
>    657 - test-linux64/debug-mochitest-e10s-5 5
>    657 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>    326 - test-linux64/debug-mochitest-e10s-12 12
>    326 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
>    266 - test-linux64/debug-mochitest-e10s-4 4
>    264 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>     88 - test-linux64/debug-mochitest-e10s-2 2
>     88 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
>     78 - test-linux64/debug-mochitest-clipboard-e10s cl
>     60 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
>     60 - test-linux64/debug-mochitest-e10s-15 15
>     46 - test-linux64/debug-mochitest-e10s-14 14
>     46 - test-linux64/debug-mochitest-e10s-3 3
>     46 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>     44 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
>     41 - test-linux64/debug-mochitest-e10s-9 9
>     41 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     40 - test-linux64/debug-mochitest-e10s-8 8
>     40 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>     36 - test-linux64/debug-mochitest-e10s-16 16
>     36 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
>     28 - test-linux64/debug-mochitest-e10s-7 7
>     26 - test-linux64/debug-mochitest-e10s-1 1
>     26 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
>     25 - test-linux64/debug-marionette-headless-e10s MnH
>     25 - test-linux64/debug-marionette-e10s Mn
>     20 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>     18 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>      8 - test-linux64/debug-mochitest-e10s-10 10
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>      8 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>      6 - test-linux64/debug-mochitest-chrome-2 c2
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      4 - test-linux64/debug-mochitest-media-e10s-1 mda1
>      2 - test-linux64/debug-mochitest-webgl-e10s-2 gl2

It shows up in 898 tests. A few of the most prevalent:

>   1032 - [e10s] layout/base/tests/test_reftests_with_caret.html
>     64 - [e10s] dom/html/test/test_fullscreen-api.html
>     56 - [e10s] dom/html/test/test_iframe_sandbox_navigation.html
>     44 - [e10s] dom/html/test/test_iframe_sandbox_general.html
>     36 - [e10s] dom/html/test/test_iframe_sandbox_popups_inheritance.html
>     32 - [e10s] testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py TestExecuteContent.test_permission
>     32 - [e10s] dom/tests/mochitest/bugs/test_bug260264_nested.html
>     24 - [e10s] layout/base/tests/test_bug977003.html
>     24 - [e10s] dom/html/test/test_iframe_sandbox_inheritance.html
>     24 - [e10s] dom/html/test/test_iframe_sandbox_navigation2.html

[1] https://hg.mozilla.org/mozilla-central/annotate/38b3c1d03a59/dom/base/nsDOMClassInfo.cpp#l1746
Hi Ehsan, just doing DOM triage. Is this worth you poking at a bit? Looking at git blame, you are one few remaining people at Mozilla who worked on it :)
Flags: needinfo?(ehsan)
Priority: -- → P3
(In reply to Marcos Caceres [:marcosc] from comment #1)
> Hi Ehsan, just doing DOM triage. Is this worth you poking at a bit? Looking
> at git blame, you are one few remaining people at Mozilla who worked on it :)

The curse of tenure.  :-)

Bobby, you added this warning in bug 790732.  I doubt it's useful any more but wanted to ask you before getting rid of it.  Would you like to keep it around for longer?
Flags: needinfo?(ehsan) → needinfo?(bobbyholley)
So, that warning means that kInterfaceShimMap [1] contains the name of an interface object that doesn't appear on the global. Manually checking those in the web console, it looks like SimpleGestureEvent is the only one that doesn't appear on a normal content global, and is thus likely the culprit. Looks like it was made ChromeOnly in bug 1251198.

This code might all go away if bug 1448046 sticks, but it should be simple enough to fix in the mean time. I can't test it easily because the Components shim is currently disabled in Nightly, but the patch is simple enough.

[1] https://searchfox.org/mozilla-central/rev/a0665934fa05158a5a943d4c8b277465910c029c/dom/base/nsGlobalWindowInner.cpp#2911
Flags: needinfo?(bobbyholley)
MozReview-Commit-ID: HRQ2rux6tcT
Attachment #8965103 - Flags: review?(bzbarsky)
Assignee: nobody → bobbyholley
Comment on attachment 8965103 [details] [diff] [review]
Remove SimpleGestureEvent from kInterfaceShims. v1

Take out the commented-out mention in js/xpconnect/tests/mochitest/test_bug790732.html too?
Attachment #8965103 - Flags: review?(bzbarsky) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c33a2801a17
Remove SimpleGestureEvent and OfflineResourceList from kInterfaceShims. r=bz
https://hg.mozilla.org/mozilla-central/rev/6c33a2801a17
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.