Closed Bug 1438085 Opened 5 years ago Closed 5 years ago

[wpt-sync] PR 9453 - Fetch API: Don't DCHECK on a 302 response with a Location header with empty value.

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

Blink was failing a DCHECK when it expected a redirect to be taken because
the request mode was 'follow' and the response had a redirect status code
and Location header. However, Chrome's //net considers a Location header
with an empty value to be the same as no Location header at all. See the
comments on bug 810288 about net::HttpResponseHeaders::IsRedirect().

WPT tests are added. The spec is unclear (https://github.com/whatwg/url/issues/373)
but seems to either say to fail with network error or enter a loop of self-redirects
that will eventually hit the redirect limit and fail with network error.
Chrome currently fails this test because it treats the Location as
as non-existent, i.e., not a redirect response.

Bug: 810288,707185
Change-Id: Iaca93976aaa697380b1542ab45d63c318f5050b0

Reviewed-on: https://chromium-review.googlesource.com/910753
WPT-Export-Revision: 807e3e33fd628d68b22cba980a4a9583f907b63b
Component: web-platform-tests → DOM
Product: Testing → Core
Priority: -- → P3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/794c66f8f16e
[wpt PR 9453] - Fetch API: Don't DCHECK on a 302 response with a Location header with empty value., a=testonly
https://hg.mozilla.org/mozilla-central/rev/794c66f8f16e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.