Closed
Bug 1438163
Opened 6 years ago
Closed 6 years ago
BroadcastChannel can leak the IPC actor when the worker thread goes away
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
3.76 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently we use a TeardownRunnable to terminate the IPC BroadcastChannel protocol. This runnable is dispatched when the worker goes away, but it's not a control runnable and it will not scheduled.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8950920 -
Flags: review?(bugs)
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Comment 2•6 years ago
|
||
Is there a test for this showing that the leak is actually fixed?
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8950920 [details] [diff] [review] bc.patch Not sure TeardownRunnable makes the code any easier to follow, but up to you.
Attachment #8950920 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1e31bd4313c BroadcastChannel must release the IPC actor using a WorkerControlRunnable when the worker thread goes away, r=smaug
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1e31bd4313c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•