1438183 - Add alert_emails fields to PREDICTOR_* Telemetry probes

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Chris H-C :chutten]

There is a family of PREDICTOR_* probes that report Telemetry. From time to time they fire off an alert (like in bug 1348460 comment #14) and it takes a while for that alert to turn into constructive action.

Mostly this is because the people who understand the probe aren't told when the alert happens.

Luckily, this can easily be fixed! Just add a list of emails to the "alerts_emails" fields of the PREDICTOR_* probes in toolkit/components/telemetry/Histograms.json and they will be notified as soon as alerts are fired.

(This is incredibly-low volume. Most probes never alert at all. The ones that do alert infrequently)

If you need any help with this, just let me know!

Comment 1

[Daniel Stenberg [:bagder]]

Predictor sounds like your ballpark Nick, care to take a look at this?

Comment 2

[u408661]

:chutten - is it legal to change the record_in_process field as well, or does that require a probe rename? Some of the older probes were labelled as collecting in both main and content processes (I assume by default whenever that field was added), but the main process is all we care about (as noted in some of the newer predictor probes). Figure, since I'm in there modifying the predictor probes, now would be a reasonable time to make the change. (I don't want to make the change if it would require a probe rename.)

Comment 3

[Chris H-C :chutten]

You can change the record_in_process field. To my knowledge, no server-side process requires that remain immutable. (To my knowledge, no server-side process reads it, except to display it)

Comment 4

[u408661]

Attachment: Bug 1438183 - Fix predictor telemetry configuration.

Review commit: https://reviewboard.mozilla.org/r/222458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222458/

Comment 5

[Daniel Stenberg [:bagder]]

Comment on attachment 8953182 [details]
Bug 1438183 - Fix predictor telemetry configuration.

https://reviewboard.mozilla.org/r/222458/#review228432

Comment 6

[u408661]

Comment on attachment 8953182 [details]
Bug 1438183 - Fix predictor telemetry configuration.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222458/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a46655064652
Fix predictor telemetry configuration. r=bagder

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a46655064652