Closed
Bug 1438207
Opened 6 years ago
Closed 6 years ago
ICO decoder does not finalize its decoded surface properly
Categories
(Core :: Graphics: ImageLib, enhancement, P3)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
2.53 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
For some strange reason, I thought nsICODecoder::FinishResource was a good place to check for the current frame of the contained decoder, and attempt to finalize the frame. However we don't even have the current frame from said decoder at this point. That is retrieved in nsICODecoder::GetFinalStateFromContainedDecoder. This code should be moved to avoid using the fallback method to share images after a GPU process crash (it cannot reallocate a file handle for a shared surface if it hasn't been finished being written to yet).
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8950965 -
Flags: review?(tnikkel)
|
|
Assignee | |
Comment 2•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fed91606dc532a5e11bf82385006d47bfff0b046
|
||
Updated•6 years ago
|
Attachment #8950965 -
Flags: review?(tnikkel) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cba9e371983 Finalize the current frame of an ICO decoder correctly. r=tnikkel
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4cba9e371983
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•