Closed Bug 1438207 Opened 2 years ago Closed 2 years ago

ICO decoder does not finalize its decoded surface properly

Categories

(Core :: ImageLib, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

For some strange reason, I thought nsICODecoder::FinishResource was a good place to check for the current frame of the contained decoder, and attempt to finalize the frame. However we don't even have the current frame from said decoder at this point. That is retrieved in nsICODecoder::GetFinalStateFromContainedDecoder. This code should be moved to avoid using the fallback method to share images after a GPU process crash (it cannot reallocate a file handle for a shared surface if it hasn't been finished being written to yet).
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
Attachment #8950965 - Flags: review?(tnikkel) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cba9e371983
Finalize the current frame of an ICO decoder correctly. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/4cba9e371983
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.