ICO decoder does not finalize its decoded surface properly

RESOLVED FIXED in Firefox 60

Status

()

Core
ImageLib
P3
normal
RESOLVED FIXED
9 days ago
7 days ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

9 days ago
For some strange reason, I thought nsICODecoder::FinishResource was a good place to check for the current frame of the contained decoder, and attempt to finalize the frame. However we don't even have the current frame from said decoder at this point. That is retrieved in nsICODecoder::GetFinalStateFromContainedDecoder. This code should be moved to avoid using the fallback method to share images after a GPU process crash (it cannot reallocate a file handle for a shared surface if it hasn't been finished being written to yet).
(Assignee)

Updated

9 days ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
(Assignee)

Comment 1

9 days ago
Created attachment 8950965 [details] [diff] [review]
0002-Bug-1438207-Finalize-the-current-frame-of-an-ICO-dec.patch, v1
Attachment #8950965 - Flags: review?(tnikkel)
Attachment #8950965 - Flags: review?(tnikkel) → review+

Comment 3

7 days ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cba9e371983
Finalize the current frame of an ICO decoder correctly. r=tnikkel

Comment 4

7 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4cba9e371983
Status: ASSIGNED → RESOLVED
Last Resolved: 7 days ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.