1438250 - Make mozunit pip installable

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

mozunit is currently not installable via pip, which means that it can't be listed as a dependency in a Pipfile. Once bug 1313547 is resolved, I would like to install mozunit via pipenv to help solve bug 1388013. I've experimented locally by simply creating /config/mozunit/mozunit/mozunit.py (and associated setup.py, __init__py, etc) with some success.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

ahal: Is there any reason we shouldn't do this? Would it perhaps also make sense to move this to /python?

Comment 2

[Andrew Halberstadt [:ahal]]

Tbh, I think I'd prefer if mozunit just didn't exist.

Right now we do `subprocess.call(['python', 'path/to/test']). Then in the test's __main__ we call mozunit.main(). Then in mozunit.main() we call pytest.main().

I think this setup is only for legacy reasons, and I don't see why we couldn't just run `subprocess.call(['pytest', 'path/to/test'])` directly from python/mach_commands.py in the first place. Though I think if we went the remove mozunit route, we'd have to block on bug 1395630.

Otherwise, I don't think there's any reason not to add a setup.py.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1438250 - Make mozunit pip installable;

Review commit: https://reviewboard.mozilla.org/r/232164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232164/

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8963270 [details]
Bug 1438250 - Make mozunit pip installable;

https://reviewboard.mozilla.org/r/232164/#review237660

This breaks |mach python-test| because `mozunit` is no longer on the python path. I think you just need to add `config/mozunit` to `build/virtualenv_packages.txt`.

::: config/mozunit/mozunit/mozunit.py:1
(Diff revision 1)
> +# This Source Code Form is subject to the terms of the Mozilla Public

I can't tell from this diff, but please make sure this was moved with `hg mv` to preserve history (drop this issue if it was).

::: config/mozunit/setup.py:1
(Diff revision 1)
> +# This Source Code Form is subject to the terms of the Mozilla Public

Please also move the `mozunit` tests under `config/test` to this directory (and make sure they pass)

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1438250 - Make mozunit pip installable;

Review commit: https://reviewboard.mozilla.org/r/232490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232490/

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8963566 [details]
Bug 1438250 - Make mozunit pip installable;

https://reviewboard.mozilla.org/r/232490/#review237912

Thanks, lgtm!

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8963566 [details]
Bug 1438250 - Make mozunit pip installable;

https://reviewboard.mozilla.org/r/232490/#review237922

::: commit-message-a4564:1
(Diff revision 1)
> +Bug 1438250 - Make mozunit pip installable; r?ahal

You'll need to also update this line:
https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/python.yml#19

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8963566 [details]
Bug 1438250 - Make mozunit pip installable;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232490/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c063db1cf370
Make mozunit pip installable; r=ahal

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c063db1cf370