1438257 - Some small cleanups in xpcom/typelib/xpt/

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438257, part 1 - Get rid of useless XPT_PUBLIC_* macros.

These macros haven't done anything since 2006, so get rid of them.

Review commit: https://reviewboard.mozilla.org/r/220288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220288/

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438257, part 2 - Get rid of extern.

We don't export these any more, so I don't think there's a reason to
mark them extern.

Review commit: https://reviewboard.mozilla.org/r/220290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220290/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438257, part 3 - C++-ize XPT files.

These are nominally in C, but I don't see any reason for that, given
that we no longer have external consumers. I got rid of "typedef
struct Foo Foo" at the same time.

Also replace a tab I noticed in the definnition of XPT_ANN_LAST.

Review commit: https://reviewboard.mozilla.org/r/220292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220292/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438257, part 4 - Remove duplicate definition of nsID.h.

Now that this file is all C++, we don't need to duplicate it.

Review commit: https://reviewboard.mozilla.org/r/220294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220294/

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8951028 [details]
Bug 1438257, part 1 - Get rid of useless XPT_PUBLIC_* macros.

https://reviewboard.mozilla.org/r/220288/#review226206

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8951029 [details]
Bug 1438257, part 2 - Get rid of extern.

https://reviewboard.mozilla.org/r/220290/#review226208

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8951030 [details]
Bug 1438257, part 3 - C++-ize XPT files.

https://reviewboard.mozilla.org/r/220292/#review226210

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8951031 [details]
Bug 1438257, part 4 - Remove duplicate definition of nsID.h.

https://reviewboard.mozilla.org/r/220294/#review226212

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecd835b0fae7
part 1 - Get rid of useless XPT_PUBLIC_* macros. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/bbd19bc1e35c
part 2 - Get rid of extern. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/72f721eccfd6
part 3 - C++-ize XPT files. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/aee4e152f0cc
part 4 - Remove duplicate definition of nsID.h. r=froydnj

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ecd835b0fae7
https://hg.mozilla.org/mozilla-central/rev/bbd19bc1e35c
https://hg.mozilla.org/mozilla-central/rev/72f721eccfd6
https://hg.mozilla.org/mozilla-central/rev/aee4e152f0cc