1438270 - Remove nsIDOMDocumentXBL

Status: RESOLVED FIXED

(Core :: XBL, enhancement)

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1438270 - Remove nsIDOMDocumentXBL.

Review commit: https://reviewboard.mozilla.org/r/220274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220274/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8951020 [details]
Bug 1438270 - Remove nsIDOMDocumentXBL.

https://reviewboard.mozilla.org/r/220274/#review226242

r=me.

::: dom/base/nsDocument.cpp:6216
(Diff revision 1)
> -                                   rv);
> -  return rv.StealNSResult();
> -}
> -
>  void
>  nsIDocument::LoadBindingDocument(const nsAString& aURI,

This is unused in mozilla-central.  Do you mind filing a Thunderbird bug about checking whether their uses are really needed?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jorg, you're going to need comm-central manifest changes here.  Also, see comment 2?

Comment 4

[Jorg K (CEST = GMT+2)]

I watch changes to package manifests by default ;-) Which Thunderbird uses do you see?

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://searchfox.org/comm-central/search?q=loadBindingDocument&case=true&path=mail%2F

And https://searchfox.org/comm-central/search?q=loadBindingDocument&case=true&path=suite in SeaMonkey.

Comment 6

[Jorg K (CEST = GMT+2)]

I know nothing about it. What does it do? Is there a replacement? Zero documentation in nsIDOMDocumentXBL.idl.

Comment 7

[Boris Zbarsky [:bzbarsky]]

It preloads the XBL binding.  But these are chrome:// bindings, so they get sync-loaded anyway when needed.  Hence there doesn't seem to be much need to preload them.

I wasn't expecting you to deal with those loadBindings calls personally, just to pass on to whoever might know about that end of the woods, assuming there is anyone.  And ideally in a separate bug, not here.

Comment 8

[Jorg K (CEST = GMT+2)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #7)
> just to pass on to whoever might know about that end of the woods, assuming
> there is anyone.
:-(

> And ideally in a separate bug, not here.
Done.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84611d1652f2
Remove nsIDOMDocumentXBL. r=bz

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/84611d1652f2