Closed Bug 1438270 Opened 2 years ago Closed 2 years ago

Remove nsIDOMDocumentXBL

Categories

(Core :: XBL, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: adrian17, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → adrian.wielgosik
Blocks: 1387169
Status: NEW → ASSIGNED
Comment on attachment 8951020 [details]
Bug 1438270 - Remove nsIDOMDocumentXBL.

https://reviewboard.mozilla.org/r/220274/#review226242

r=me.

::: dom/base/nsDocument.cpp:6216
(Diff revision 1)
> -                                   rv);
> -  return rv.StealNSResult();
> -}
> -
>  void
>  nsIDocument::LoadBindingDocument(const nsAString& aURI,

This is unused in mozilla-central.  Do you mind filing a Thunderbird bug about checking whether their uses are really needed?
Attachment #8951020 - Flags: review?(bzbarsky) → review+
Jorg, you're going to need comm-central manifest changes here.  Also, see comment 2?
Flags: needinfo?(jorgk)
I watch changes to package manifests by default ;-) Which Thunderbird uses do you see?
Flags: needinfo?(jorgk) → needinfo?(bzbarsky)
I know nothing about it. What does it do? Is there a replacement? Zero documentation in nsIDOMDocumentXBL.idl.
It preloads the XBL binding.  But these are chrome:// bindings, so they get sync-loaded anyway when needed.  Hence there doesn't seem to be much need to preload them.

I wasn't expecting you to deal with those loadBindings calls personally, just to pass on to whoever might know about that end of the woods, assuming there is anyone.  And ideally in a separate bug, not here.
Depends on: 1438328
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #7)
> just to pass on to whoever might know about that end of the woods, assuming
> there is anyone.
:-(

> And ideally in a separate bug, not here.
Done.
https://hg.mozilla.org/mozilla-central/rev/84611d1652f2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.