Closed Bug 1438278 Opened 2 years ago Closed 2 years ago

Move {json,jsgc,jshashutil,jsweakmap,jsdtoa,jswin,jsnativestack,jsnspr,jsiter,jsopcode}.* into subdirectories

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

These are the non-public files that I think can be trivially renamed, with #includes and include-guard identifiers updated.

Disclaimer: Throughout this process there are going to be files that should be split up instead, etc. I'm just renaming things this time through. I think that's valuable enough (and hard enough) by itself.
Priority: -- → P3
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
jsgc.* -> gc/GC.*
jshashutil.h -> gc/HashUtil.h
jsweakmap.* -> gc/WeakMap.*
vm/WeakMapPtr.cpp -> gc/WeakMapPtr.cpp
Attachment #8951682 - Flags: review?(jdemooij)
jsdtoa.* -> util/DoubleToString.*
jswin.h -> util/Windows.h
jsnativestack.cpp -> util/NativeStack.cpp
jsnativestack.h -> util/NativeStack.h
jsnspr.h -> util/NSPR.h
Attachment #8951683 - Flags: review?(jdemooij)
Attachment #8951683 - Attachment description: Part 3: Rename some files into js/src/util → Part 4: Rename some files into js/src/util
Attachment #8951677 - Flags: review?(jcoppeard) → review+
jsiter* -> vm/Iteration*
jsopcode* -> vm/BytecodeUtil*
Attachment #8951686 - Flags: review?(jdemooij)
Attachment #8951648 - Flags: review?(jdemooij) → review+
Comment on attachment 8951682 [details] [diff] [review]
Part 3: Rename some files into js/src/gc

Review of attachment 8951682 [details] [diff] [review]:
-----------------------------------------------------------------

Forwarding to jonco since this moves/renames the main GC file.
Attachment #8951682 - Flags: review?(jdemooij) → review?(jcoppeard)
Comment on attachment 8951683 [details] [diff] [review]
Part 4: Rename some files into js/src/util

Review of attachment 8951683 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/DataViewObject.cpp
@@ +17,5 @@
>  #include "jswrapper.h"
>  
>  #include "jit/AtomicOperations.h"
>  #include "js/Conversions.h"
> +#ifdef XP_WIN

All these #ifdef XP_WIN guards are unnecessary because util/Windows.h checks it too... How do you feel about removing them? r=me either way.
Attachment #8951683 - Flags: review?(jdemooij) → review+
Comment on attachment 8951686 [details] [diff] [review]
Part 5: Rename some files into js/src/vm

Review of attachment 8951686 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.
Attachment #8951686 - Flags: review?(jdemooij) → review+
Comment on attachment 8951682 [details] [diff] [review]
Part 3: Rename some files into js/src/gc

Review of attachment 8951682 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/GC.h
@@ +143,5 @@
>  #ifdef JS_GC_ZEAL
>  
>  extern const char* ZealModeHelpText;
>  
> +/* Check that write barriers have been used correctly. See gc/Verifier.cpp. */

Thanks for fixing these references.
Attachment #8951682 - Flags: review?(jcoppeard) → review+
Comment on attachment 8951694 [details] [diff] [review]
Part 6: Remove unnecessary #ifdef XP_WIN guards around #include "util/Windows.h"

Marking r=jandem per comment 9.
Attachment #8951694 - Flags: review+
Comment on attachment 8951711 [details] [diff] [review]
Part 0: Fix places where bug 1429206 left old filenames in comments

This goes at the bottom of the stack. Carrying over r=jandem from bug 1437955, where I originally posted this patch by mistake.
Attachment #8951711 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/02d24f7856d50c678016cd33292882217ce29f36
Bug 1438278 - Part 0: Fix places where bug 1429206 left old filenames in comments. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/745176a7ab4a5197f3e2b77c749b4559a7a5b4c4
Bug 1438278 - Part 1: Rename json.* -> builtin/JSON.*. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/249a7398961afcefa7a6c1f2b9172d8c85e9104a
Bug 1438278 - Part 2: Rename a template because there is another global template with the same name in jsgc.cpp. r=jonco.

https://hg.mozilla.org/integration/mozilla-inbound/rev/08702628464616ad69c49390f121e9342e9d625f
Bug 1438278 - Part 3: Rename some files into js/src/gc. r=jonco.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ceed0fcb88258a867879388d84b3a41953da431
Bug 1438278 - Part 4: Rename some files into js/src/util. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/091e9b26d9a14feba8f49355a3b03e185d253152
Bug 1438278 - Part 5: Rename some files into js/src/vm. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3ee97dce95a8d672f6a7445a132389cfeeb53eb
Bug 1438278 - Part 6: Remove unnecessary #ifdef XP_WIN guards around #include "util/Windows.h". r=jandem.
You need to log in before you can comment on or make changes to this bug.