1438315 - Pinned jobs take a long time to show the annotation

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Comment 1

[Phil Ringnalda (:philor)]

This will be a little difficult to spot for people who don't classify all day.

It has always been the case that classifying through the Failure Summary tab immediately marks the job as classified, thus removing it from view if you are only showing unstarred failures, and decrements the unstarred count, and that's still the case today.

Prior to today, classifying through the Failure Classification tab would immediately mark the job as classified, removing it from view, but the unstarred failure count wouldn't decrement until the next time the page auto-refreshed (bug some-rather-small-number). Now, when you classify through Failure Classification, neither the marking nor the decrementing happens until the next page auto-refresh, or sometimes the job gets a star next to it, but doesn't actually disappear from the only-unstarred view.

Comment 3

[Phil Ringnalda (:philor)]

Bug not-all-that-small-a-number actually, bug 1306919 for the not new not a regression failure to decrement the count.

Comment 4

[Phil Ringnalda (:philor)]

No idea whether this actually means anything, but I was interested to note that there's another alternative to waiting until the next page refresh: just classify something else. Classify failure 1, it looks unchanged in the UI; type N to go to failure 2 and failure 1 grows a * after it; classify failure 2 and failure 1 disappears from the only-unstarred view. So it looks a lot like something is trying to update the job display after a classification, but it's doing it with an off-by-one error.

Comment 5

[Andreea Pavel [:apavel]]

:philor hi, i tested what you mentioned above, however it did not work for me. failure 1 did not disappear nor did it have a * after moving to failure 2.

Comment 6

[Cameron Dawson [:camd]]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1c9b2c0e2498151e7f10c7fb6824e00a321a3e0f
Bug 1438555 -Fix n/p after classifying a failure

This also fixes Bug 1438315 - Pinned jobs take a long time
to show the annotation. These two bugs were related so it
made sense to fix them at the same time.