Port |Bug 1438270 - Remove nsIDOMDocumentXBL| to C-C

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

Last year
+++ This bug was initially created as a clone of Bug #1438270 +++

https://searchfox.org/comm-central/search?q=loadBindingDocument&case=true&path=mail%2F
And https://searchfox.org/comm-central/search?q=loadBindingDocument&case=true&path=suite in SeaMonkey.

These calls need to be removed. Also see bug 1438270 comment #7.

Richard, Aceman, you know anything about this?
Flags: needinfo?(richard.marti)
Flags: needinfo?(acelists)
> These calls need to be removed. 

To be clear, they do not need to be removed just to get bug 1438270 landed.  They continue to work from JS.

But I'd like to remove them (as a separate fix from bug 1438270), so would like to understand whether they're really needed in comm-central code.
Assignee

Comment 2

Last year
Attachment #8951067 - Flags: review?(acelists)
I know nothing about this. And it seems you found the needed solution.
Flags: needinfo?(richard.marti)
Assignee

Comment 5

Last year
I need to remove dom_xbl.xpt from the package manifests now, or else we're busted. As per comment #1, no need to land the other patch just yet.
Keywords: leave-open

Comment 6

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9979f414b1af
Port bug 1438270 to TB/IB/SM: remove dom_xbl.xpt from package manifests. rs=bustage-fix

Comment 7

Last year
Comment on attachment 8951067 [details] [diff] [review]
1438328-remove-loadBindingDocument.patch

Review of attachment 8951067 [details] [diff] [review]:
-----------------------------------------------------------------

OK, let's try this. I haven't seen any visible problems while loading messages and also all tests pass: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c0185d8a574c55e144fc3cb43d91fcaa985df743
Attachment #8951067 - Flags: review?(acelists) → review+

Updated

Last year
Attachment #8951189 - Flags: review+
Assignee

Updated

Last year
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Flags: needinfo?(acelists)
Keywords: leave-open

Comment 8

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8f403ab50774
Port bug 1438270 to C-C: Remove use of nsIDOMDocumentXBL.loadBindingDocument(). r=aceman
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Assignee

Updated

Last year
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.