Closed
Bug 1438342
Opened 6 years ago
Closed 6 years ago
Context menu doesn't work for media elements in GeckoView
Categories
(GeckoView :: Media, enhancement)
Tracking
(firefox59 verified, firefox60 verified)
VERIFIED
FIXED
mozilla60
People
(Reporter: droeh, Assigned: droeh)
Details
Attachments
(1 file)
1.36 KB,
patch
|
snorp
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per comments in bug 1411529, context menus won't work on media elements because we're checking if the node's classname is HTMLMediaElement rather than the concrete HTMLVideoElement and HTMLAudioElement classes.
Assignee | ||
Comment 1•6 years ago
|
||
This checks against HTMLVideoElement and HTMLAudioElement instead of HTMLMediaElement. Confirmed to fix the issue in custom tabs.
Assignee: nobody → droeh
Attachment #8951075 -
Flags: review?(snorp)
Attachment #8951075 -
Flags: review?(snorp) → review+
Dylan do we need uplift on this?
Flags: needinfo?(droeh)
Pushed by droeh@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e976b6442e9f Fix context menu for media elements in GV. r=snorp
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e976b6442e9f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8951075 [details] [diff] [review] Fix context menus for media elements Approval Request Comment [Feature/Bug causing the regression]:1411529 [User impact if declined]:Context menus will not work on media elements in custom tabs and PWAs. [Is this code covered by automated tests?]:No [Has the fix been verified in Nightly?]:No [Needs manual test from QE? If yes, steps to reproduce]: Long press any html 5 video in a custom tab. [List of other uplifts needed for the feature/fix]:None [Is the change risky?]:No [Why is the change risky/not risky?]:It only impacts custom tabs and PWAs, and simply changes what element type we look for to determine if a user is long-pressing a media element. [String changes made/needed]:
Flags: needinfo?(droeh)
Attachment #8951075 -
Flags: approval-mozilla-beta?
Comment 6•6 years ago
|
||
Comment on attachment 8951075 [details] [diff] [review] Fix context menus for media elements Regression from 58. Let's uplift this fix for 59 beta 11.
Attachment #8951075 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/73e1a4362495
status-firefox59:
--- → fixed
Verified as fixed on the latest 59.0b11 build. The "Open in Firefox Beta" context menu appears when a long press action is performed on media elements in PWA and Custom tabs. This issue was tested using a Sony Xperia Z3 - Android 5.1.1 And Samsung galaxy Tab S3 - Android 7.0
Comment 9•6 years ago
|
||
Verified as fixed on latest Nightly build. Devices: Oneplus Two (Android 6.0.1) and Samsung Galaxy Tab S3 (Android 7.0).
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 60 → mozilla60
Comment 10•2 years ago
|
||
Moving some media bugs to the new GeckoView::Media component.
Component: General → Media
You need to log in
before you can comment on or make changes to this bug.
Description
•