1438348 - AttributeError: 'MochitestDesktop' object has no attribute 'manifest'

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

When running `./mach mochitest dom/media/test/test_mediarecorder_avoid_recursion.html --use-test-media-devices` on a Linux machine without the required v4l2loopback device the tests should fail. However, this also results in mach failing which is unexpected. I think this could be worked around by initing the value of self.manifest to None in MochitestDesktop's init. Will provide a patch shortly. Error below.

---

SUITE-START | Running 1 tests
Running manifest: dom/media/test/mochitest.ini
Couldn't find a v4l2loopback video device
Could not find test media devices to use
Buffered messages finished
Error running mach:

    ['mochitest', 'dom/media/test/test_mediarecorder_avoid_recursion.html', '--use-test-media-devices']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'MochitestDesktop' object has no attribute 'manifest'

  File "/home/b/projects/mozilla/mozilla-central/testing/mochitest/mach_commands.py", line 415, in run_mochitest_general
    **harness_args)
  File "/home/b/projects/mozilla/mozilla-central/testing/mochitest/mach_commands.py", line 152, in run_desktop_test
    result = mochitest.run_test_harness(parser, options)
  File "/home/b/projects/mozilla/mozilla-builds/obj-ff-dbg/_tests/testing/mochitest/runtests.py", line 3063, in run_test_harness
    result = runner.runTests(options)
  File "/home/b/projects/mozilla/mozilla-builds/obj-ff-db

---

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1438348 - Init MochitestDesktop's self.manifest to None to prevent attrib error.

Review commit: https://reviewboard.mozilla.org/r/220326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220326/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8951078 [details]
Bug 1438348 - Init MochitestDesktop's self.manifest to None to prevent attrib error.

https://reviewboard.mozilla.org/r/220326/#review226444

Thanks!

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8951078 [details]
Bug 1438348 - Init MochitestDesktop's self.manifest to None to prevent attrib error.

https://reviewboard.mozilla.org/r/220326/#review226446

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ee24bbfd93e
Init MochitestDesktop's self.manifest to None to prevent attrib error. r=ahal

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ee24bbfd93e