1438410 - Filing with bugfiler from Failure Summary tab gives "Please classify this failure before saving" error instead of saving the classification after using bugfiler

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Phil Ringnalda (:philor)]

STR:
1. Select a failed job, and if your identity pushes you into the Failure Classification panel, switch to the Failure Summary panel
2. Click the bug icon at the start of a failure line to "file a bug for this failure"
3. (umm, you're somehow testing this where you aren't filing an actual bug in production bmo, right?) Pick a product/component, and file the bug, and close the bmo window that opens with the bug you filed and return to the treeherder tab where you filed from

Expected: it's different for the Classification panel, which expects that every line is a completely separate thing and that they must all be dealt with separately, but the way filing a bug from the Summary panel has always worked is that while the browser tab with your bug is opening, the treeherder tab is saving the classification as that bug, so when you get back you should see that the failure has been starred

Actual: as of today, if you are very fast at coming back you will see a notification telling you to "Please classify this failure before saving", or if you come back at any normal sort of speed, that notification will be gone (though still visible behind the bell icon if you think to look there), and although your new bug number has been filled in in the pinboard, it hasn't been saved.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3272

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ac12ac0d77ca0ee95200ec8a22c9b7fee06af93f
Bug 1438410 - Fix filing with bugfiler from Failure Summary tab

This was using an angular $timeout in the thPinboard service addBug
function.  That caused the value to not be persisted.  Moved the $timeout
to the ReactJS failure_summary_panel since that's where it's needed.

Comment 4

[Andreea Pavel [:apavel]]

:camd hi, I still got this warning message when filing a bug today.

Comment 5

[Ed Morley [:emorley]]

Treeherder help menu -> "What's deployed" -> https://whatsdeployed.io/s-pdF

(this hasn't been deployed yet - we'll do one shortly)