Closed Bug 1438423 Opened 4 years ago Closed 4 years ago

test_0171_check_noPerms_manual.xul and test_0172_notify_noPerms_manual.xul fail when run with the ability to elevate

Categories

(Toolkit :: Application Update, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

If the client running the test can elevate the check of the file in the app dir that is locked is skipped.

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#431
Attached patch patch rev1Splinter Review
Change the tests to lock the file in the updates directory
Attachment #8951137 - Flags: review?(mhowell)
Attachment #8951137 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/761e1bc8ac96
make it so the test_0171_check_noPerms_manual.xul and test_0172_notify_noPerms_manual.xul tests pass when they are run with the ability to elevate. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/761e1bc8ac96
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.