Closed
Bug 1438423
Opened 6 years ago
Closed 6 years ago
test_0171_check_noPerms_manual.xul and test_0172_notify_noPerms_manual.xul fail when run with the ability to elevate
Categories
(Toolkit :: Application Update, enhancement)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
If the client running the test can elevate the check of the file in the app dir that is locked is skipped. https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#431
|
Assignee | |
Comment 1•6 years ago
|
||
Change the tests to lock the file in the updates directory
Attachment #8951137 -
Flags: review?(mhowell)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed to try with a couple of other patches https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a2ed5feada5749918a9c433fccb2d6501a76bdf
|
||
Updated•6 years ago
|
Attachment #8951137 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/761e1bc8ac96 make it so the test_0171_check_noPerms_manual.xul and test_0172_notify_noPerms_manual.xul tests pass when they are run with the ability to elevate. r=mhowell
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/761e1bc8ac96
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•