1438424 - test_0085_error_patchApplyFailure_partial_complete_staging.xul fails when all tests are run with --verify

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_0085_error_patchApplyFailure_partial_complete_staging.xul | uncaught exception - NS_ERROR_FILE_ALREADY_EXISTS: Component returned failure code: 0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsIFile.create] at writeFile@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/data/shared.js:276:5
writeUpdatesToXMLFile@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/data/shared.js:201:3
runTest@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/test_0085_error_patchApplyFailure_partial_complete_staging.xul:72:3
copyTestUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:747:3
moveRealUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:718:3
setupTestUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:696:3

What is happening is an earlier write of the xml file is in the process when trying to write the test file.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Removing the reload when the test starts fixes this

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to try with a couple of other patches
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a2ed5feada5749918a9c433fccb2d6501a76bdf

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1b8cac2508c
make it so the test_0085_error_patchApplyFailure_partial_complete_staging.xul test pass when all tests are run with --verify. r=mhowell

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f1b8cac2508c