Closed Bug 1438424 Opened 4 years ago Closed 4 years ago

test_0085_error_patchApplyFailure_partial_complete_staging.xul fails when all tests are run with --verify

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

patch rev1
893 bytes, patch
mhowell
: review+
Details | Diff | Splinter Review 
TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_0085_error_patchApplyFailure_partial_complete_staging.xul | uncaught exception - NS_ERROR_FILE_ALREADY_EXISTS: Component returned failure code: 0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsIFile.create] at writeFile@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/data/shared.js:276:5
writeUpdatesToXMLFile@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/data/shared.js:201:3
runTest@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/test_0085_error_patchApplyFailure_partial_complete_staging.xul:72:3
copyTestUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:747:3
moveRealUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:718:3
setupTestUpdater@chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js:696:3

What is happening is an earlier write of the xml file is in the process when trying to write the test file.
Attached patch patch rev1 — — Splinter Review 
Removing the reload when the test starts fixes this
Attachment #8951145 - Flags: review?(mhowell)
Attachment #8951145 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1b8cac2508c
make it so the test_0085_error_patchApplyFailure_partial_complete_staging.xul test pass when all tests are run with --verify. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/f1b8cac2508c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.