Closed
Bug 1438449
Opened 6 years ago
Closed 6 years ago
Remove unnecessary feature string in serde_derive patch
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
https://searchfox.org/mozilla-central/rev/9011be0a172711bc243e50dfca16d42e877bf4ec/toolkit/library/rust/Cargo.toml#52 has a 'feature = "deserialize_in_place"' property which apparently is not used by cargo. The correct property name is 'features', not 'feature', and it takes an array of feature strings. But we're geting the desired behaviour even without specifying this feature so we can just drop it. This will eliminate the warning that cargo spits out during the build.
| Comment hidden (mozreview-request) |
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
||
Updated•6 years ago
|
Blocks: stage-wr-trains
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951172 [details] Bug 1438449 - Remove unused feature property from crate override. https://reviewboard.mozilla.org/r/220438/#review226550
Attachment #8951172 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e5a696fe608 Remove unused feature property from crate override. r=jrmuizel
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1e5a696fe608
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•