Closed Bug 1438463 Opened 3 years ago Closed 3 years ago

Clicking on the location in browser console with new frontend throws

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

**Steps to reproduce**
1. Open the browser console
2. Click on a random location link


**Expected results**

The old frontend used to open the raw file in a new tab

**Actual results**


There's an error thrown: 
```
TypeError: onClick is not a function Frame.js:223:11
```

---

Looks like we don't set up onClick well in the case of the browser console.
Priority: -- → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8952103 [details]
Bug 1438463 - Fix click on location in browser console with new frontend; .

https://reviewboard.mozilla.org/r/221326/#review227186
Attachment #8952103 - Flags: review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43390eee8142
Fix click on location in browser console with new frontend; r=nchevobbe.
OOOps, mistook this patch for another one (even r+d it because I thought mozreview wasn't working …), let's have another coffee.
Also, I still want you to review the patch, and if you have comments I'll address them in a follow-up.
https://hg.mozilla.org/mozilla-central/rev/43390eee8142
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
Comment on attachment 8952103 [details]
Bug 1438463 - Fix click on location in browser console with new frontend; .

clearing flag since this already landed quite some time ago
Attachment #8952103 - Flags: review?(bgrinstead)
You need to log in before you can comment on or make changes to this bug.