Closed Bug 1438478 Opened 4 years ago Closed 4 years ago

[wpt-sync] PR 9536 - Isolate MemoryCache entries for each source origin.

Categories

(Core :: DOM: Security, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog3])

ResourceFetcher/ResourceLoader now saves the result of the CORS check on
the Resource object. Though the result of the CORS check varies
depending on the source origin, reusing an existing resource fetched by
a different source origin is allowed by mistake.

This patch introduces a logic to isolate MemoryCache entries for each
source origin by saving the source origin on the Resource object and
comparing that with the new source origin in Resource::CanReuse(), so
that the result of the CORS check is reused only when the source origin
is the same.

Bug: 799477, 809350
Change-Id: Ib96c9e728abe969a53f3d80519118a83392067b4
Reviewed-on: https://chromium-review.googlesource.com/897040
WPT-Export-Revision: b7c695bbc4ccaa074609dca17ddbb9d336964eef
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
James, are we supposed to do anything with those kinds of bugs within dom:security? It seems there are more bugs within our component that are filed from the sync bot. Thanks!
Flags: needinfo?(james)
This bug will eventually be closed when the changes are landed on m-c. There's a bit of a delay with that at the moment (teething issues in a new system). The bot is supposed to set issues as P3, so hopefully they don't interfere with normal triage. In cases that the imported tests cause bad results (new failures, regressions, etc.) then those will be reported in the bug. The intent is that that's helpful to people working on the component to become aware of new problems that the tests reveal.
Flags: needinfo?(james)
Priority: -- → P3
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog3]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9e926e5f731
[wpt PR 9536] - Stop reusing MemoryCache entries for requests with a different source origin., a=testonly
https://hg.mozilla.org/mozilla-central/rev/d9e926e5f731
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.