1438531 - Remove leftovers of mocha test from netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement)

Description

[Alexandre Poirot [:ochameau]]

One mocha test for netmonitor has been introduced in bug 1309496, but has been removed in bug 1350217.
But we still have this test here:
  https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/components/filter-buttons.test.js

It appears that this test is left unmaintained and has broken path like:
  const { configureStore } = require("devtools/client/netmonitor/store");

I saw that while trying to make the console mocha test to work:
  Cannot find module 'devtools/client/netmonitor/store'
  ---
  at:
    line: 470
    column: 15
    file: module.js
    function: Function.Module._resolveFilename
  stack: >
    Function._module2.default._resolveFilename
    (node_modules/require-hacker/babel-transpiled-modules/require
    hacker.js:423:34)
  
    Object.<anonymous>
    (node_modules/devtools-mc-assets/assets/devtools/client/netmonitor/test/components/filter-buttons.test.js:11:28)


We may need to update devtools-mc-assets after that.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1438531 - Remove leftovers of mocha test from netmonitor.

Review commit: https://reviewboard.mozilla.org/r/221406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221406/

Comment 2

[Alexandre Poirot [:ochameau]]

green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33d9932e3cb1e77c3bb7c07acf966d5d29229378

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8952159 [details]
Bug 1438531 - Remove leftovers of mocha test from netmonitor.

https://reviewboard.mozilla.org/r/221406/#review227212

Looks reasonable, thanks for the clean up.

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/737477b7b0c6
Remove leftovers of mocha test from netmonitor. r=Honza

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/737477b7b0c6