Closed Bug 1438533 Opened 8 years ago Closed 1 year ago

Style checker should check for missing explicit keyword on single argument constructors

Categories

(Core :: JavaScript Engine, enhancement, P5)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: jonco, Unassigned)

Details

We have a static analysis build that enforces the rule that single argument constructors are either marked with explicit or MOZ_IMPLICIT. It would be great if our style checker would check this too and save me the embarrassment of breaking inbound every week.
Severity: normal → enhancement
Priority: -- → P5
Severity: normal → S3

These days I'd just recommended building with --enable-clang-plugin before landing; and Lando ought to catch some of this.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.