1438599 - Update fdlibm to 2018-02-14 07:59:30

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Ritter [:tjr]]

https://github.com/freebsd/freebsd/commit/b21ccf63f28a3a4692d8a31419e0a725a1b1a800#diff-227c3d72c0aad108bfa20fb876c89262

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

fdlibm is currently at version 2016-09-04 12:01:32 in mozilla-central, and the latest version of the library released is 2018-02-14 07:59:30. 

I fetched the latest version of the library from https://github.com/freebsd/freebsd/commits/master/lib/msun/src/e_atan2.c.

Comment 1

[Tooru Fujisawa [:arai]]

Thanks :)
it's the upstream fix for bug 1437729.

I'll re-generate patches this time.

Comment 2

[Tooru Fujisawa [:arai]]

try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43812df8a679310a761ae5a6935403165d99d2dd

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 0: Echo the applying patch in fdlibm update script.

Just to make the patching process easier, added logging for applying patch filename

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Rebase local patches for fdlibm.

Rebased patches onto the FreeBSD trunk.
also removed the patch added by bug 1437729.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Import fdlibm from FreeBSD (revision b21ccf63f28a3a4692d8a31419e0a725a1b1a800).

And the result of "sh update.sh"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b42d3420019f
Part 0: Echo the applying patch in fdlibm update script. r=jwalden
https://hg.mozilla.org/integration/mozilla-inbound/rev/724ddaceae8c
Part 1: Rebase local patches for fdlibm. r=jwalden
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d759872b174
Part 2: Import fdlibm from FreeBSD (revision b21ccf63f28a3a4692d8a31419e0a725a1b1a800). r=jwalden

Comment 7

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b42d3420019f925a6371a9f2b9ced3f53d815462
Bug 1438599 - Part 0: Echo the applying patch in fdlibm update script. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/724ddaceae8c7347cbd85c81b89950d3355e042e
Bug 1438599 - Part 1: Rebase local patches for fdlibm. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d759872b1743c1ab44acfd984536f6bb4d35064
Bug 1438599 - Part 2: Import fdlibm from FreeBSD (revision b21ccf63f28a3a4692d8a31419e0a725a1b1a800). r=jwalden

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b42d3420019f
https://hg.mozilla.org/mozilla-central/rev/724ddaceae8c
https://hg.mozilla.org/mozilla-central/rev/7d759872b174