Closed Bug 1438618 Opened 2 years ago Closed 2 years ago

Remove unused using declarations

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file, 1 obsolete file)

Remove unused |using| declarations reported by "misc-unused-using-decls" clang-tidy check.
Attached patch bug1438618.patch (obsolete) — Splinter Review
I noticed there were some unused 'using' declarations in the new Intl cpp-files and applying clang-tidy revealed some more cases in other cpp-files. When it was easily decidable which #includes can be removed, I've also removed the #includes for the unused 'using' declarations.
Attachment #8951368 - Flags: review?(jwalden+bmo)
Comment on attachment 8951368 [details] [diff] [review]
bug1438618.patch

Review of attachment 8951368 [details] [diff] [review]:
-----------------------------------------------------------------

There appear to be a lot of usings of things whose headers aren't listed in these files, but I guess that's a separate concern from this.  Looks fine otherwise.
Attachment #8951368 - Flags: review?(jwalden+bmo) → review+
Attached patch bug1438618.patchSplinter Review
Rebased to apply on inbound. Carrying r+.
Attachment #8951368 - Attachment is obsolete: true
Attachment #8952149 - Flags: review+
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/040692f892ab
Remove unused using declarations. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/040692f892ab
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.