1438631 - Stop using D2D to paint masks with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

perfht.ml/2swE6fc

Comment 1

[Jeff Muizelaar [:jrmuizel]]

https://perfht.ml/2swE6fc

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1438631. Use a similar drawtarget when painting masks.

Avoiding an offscreen drawtarget will avoid using Direct2D with webrender,
let us record the masking operation, and also give us OMTP.

Review commit: https://reviewboard.mozilla.org/r/220648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220648/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8951385 [details]
Bug 1438631. Use a similar drawtarget when painting masks.

https://reviewboard.mozilla.org/r/220648/#review226614

::: layout/svg/nsSVGMaskFrame.cpp:91
(Diff revision 1)
> -    maskDT = gfxPlatform::GetPlatform()->CreateOffscreenContentDrawTarget(
> +    maskDT = ctx->GetDrawTarget()->CreateSimilarDrawTarget(
>                 maskSurfaceSize, SurfaceFormat::B8G8R8A8);

Same question as always: If we're drawing to a non-tiled component alpha layer, will this create a DrawTargetDual? If we paint to a tiled layer, will it create a DrawTargetTiled?

I think we resolved this question in a satisfying way at some point but I don't remember what we ended up with.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to Markus Stange [:mstange] from comment #3)
> Comment on attachment 8951385 [details]
> Bug 1438631. Use a similar drawtarget when painting masks.
> 
> https://reviewboard.mozilla.org/r/220648/#review226614
> 
> ::: layout/svg/nsSVGMaskFrame.cpp:91
> (Diff revision 1)
> > -    maskDT = gfxPlatform::GetPlatform()->CreateOffscreenContentDrawTarget(
> > +    maskDT = ctx->GetDrawTarget()->CreateSimilarDrawTarget(
> >                 maskSurfaceSize, SurfaceFormat::B8G8R8A8);
> 
> Same question as always: If we're drawing to a non-tiled component alpha
> layer, will this create a DrawTargetDual?
No

> If we paint to a tiled layer, will it create a DrawTargetTiled?

No

Those are the answers we want in both cases.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8951385 [details]
Bug 1438631. Use a similar drawtarget when painting masks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220648/diff/1-2/

Comment 6

[Jeff Muizelaar [:jrmuizel]]

This is causing reftest failures with webrender

Comment 7

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01334f99a36aa3787752d0de7b930ab6269ddd08

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Looks like the failures are really crashes, and they're perma versions of bug 1437813. We should fix that.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8951385 [details]
Bug 1438631. Use a similar drawtarget when painting masks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220648/diff/2-3/

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8951385 [details]
Bug 1438631. Use a similar drawtarget when painting masks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220648/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3907766823e6
Fix typos in IntoLuminance recording event.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b7d400749d3
Use a similar drawtarget when painting masks. r=mstange

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3907766823e6
https://hg.mozilla.org/mozilla-central/rev/2b7d400749d3