Closed Bug 1438638 Opened 4 years ago Closed 3 years ago

global-alpha.html reftest failures on windows 10 new hardware with intel graphics card

Categories

(Core :: Canvas: 2D, defect, P3)

54 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

I verified that adding a fuzzy-if allows this to pass:
fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu)||azureSkia,1,1500) == global-alpha.html global-alpha-ref.html
Summary: drop-shadow-transformed.html reftest failures on windows 10 new hardware with intel graphics card → global-alpha.html reftest failures on windows 10 new hardware with intel graphics card
Whiteboard: [gfx-noted]
Comment on attachment 8951393 [details] [diff] [review]
adjust filters to allow test to pass

I would like to fuzzy-if and leave this open until there are dev cycles to look into this
Attachment #8951393 - Flags: review?(gbrown)
Attachment #8951393 - Flags: review?(gbrown) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/038690d5805c
global-alpha.html reftest failures on windows 10 new hardware, add fuzzy-if. r=gbrown
Keywords: leave-open
The leave-open keyword is there and there is no activity for 6 months.
:lsalzman, maybe it's time to close this bug?
Flags: needinfo?(lsalzman)
This just looks like a slight different in rounding when certain types of blending are used (only off by 1 increment). Given that we're already seeing this with Skia, I think it is reasonable to just leave the fuzz in place and call it good, given that this bug is not being actively investigated further.
Assignee: nobody → jmaher
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(lsalzman)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.