Closed
Bug 1438670
Opened 6 years ago
Closed 6 years ago
Rename gc/Iteration files one more time
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(2 files)
|
14.45 KB,
patch
|
pbone
:
review+
|
Details | Diff | Splinter Review |
|
20.38 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Bug 1437602 did a couple odd things. - js/src/gc/Iteration-inl.h was renamed to GCIteration-inl.h, but Iteration.h and Iteration.cpp were not renamed. - The #ifndef guard in gc/GCIteration-inl.h is gc_GCIteration_h rather than gc_GCIteration_inl_h. I have a patch that I think fixes both of these; building now...
|
Assignee | |
Comment 1•6 years ago
|
||
There are also some comments in the bug mentioning GCIterators.h, but it looks like the actual patch always says GCIteration.h, never GCIterators.h, so I will leave it like that.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8951442 -
Flags: review?(pbone)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8951442 [details] [diff] [review] Fix gc/GCIteration filenames Review of attachment 8951442 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this Jason.
Attachment #8951442 -
Flags: review?(pbone) → review+
|
||
Comment 4•6 years ago
|
||
(In reply to Jason Orendorff [:jorendorff] from comment #0) > - js/src/gc/Iteration-inl.h was renamed to GCIteration-inl.h, but > Iteration.h and Iteration.cpp were not renamed. This part was intentional. Originally the idea was to have GCIteration.h for GC-internal APIs and Iteration.h for APIs used by the rest of the engine. However, the style checker required me to call the former GCIteration-inl.h since it includes jsgcinlines.h (and eventually gc/ArenaLists-inl.h). I'm not sure what the best solution is here or what the .cpp file should be called.
Flags: needinfo?(jorendorff)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8951646 -
Flags: review?(jcoppeard)
|
|
||
Updated•6 years ago
|
Attachment #8951646 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Updated•6 years ago
|
Severity: normal → trivial
status-firefox60:
--- → fix-optional
Flags: needinfo?(jorendorff)
Priority: -- → P3
Summary: Fix gc/GCIteration filenames → Rename gc/Iteration files one more time
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dc56cddadcd2e0a428a08b0b00f5544057da4cd Bug 1438670 - Tweak gc/GCIteration filenames one more time. r=jonco.
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2dc56cddadcd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•