1438672 - tabs.create() resolves at about:blank before loading the URL

Status: RESOLVED DUPLICATE of bug 1416087

(WebExtensions :: Frontend, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: test.xpi

1. Install attached extension
2. Open browser console
3. Click the browser action button
4. A new tab opens: http://example.com

Result: the browser console shows "URL: about:blank"
Expected: the browser console shows "URL: http://example.com/", like Chrome

The code is

    let tab = await browser.tabs.create({active: true, url: "http://example.com"});
    console.log("URL: " + tab.url);

This does not seem a big problem, but it is. It means the tab will navigate from about:blank to http://example.com after resolving browser.tabs.create(). And browser and page actions should be cleared when there is a navigation.

Currently they are not cleared because of bug 1438274. I already have a fix for that, but it would imply that

    let tab = await browser.tabs.create({active: true, url: "http://example.com"});
    browser.browserAction.disable(tab.id);

would end up with an enabled browser action. This is not compatible with Chrome.

So this must be fixed first. There should be no navigation after browser.tabs.create()

Comment 1

[Andrew Swan [:aswan]]

The duplicate is about windows.create() but the issue is the same.
In short, the target page isn't loaded when tabs.create() returns, you should use tabs.onUpdated to watch for a status of "complete"

Comment 2

[Oriol Brufau [:Oriol]]

(In reply to Oriol Brufau [:Oriol] from comment #0)
> would end up with an enabled browser action. This is not compatible with Chrome

It seems I didn't test Chrome properly.

Chrome returns the proper url, but that code ends up with an enabled browser action.

So in fact it's the opposite of what I thought. Fixing bug 1438274 without fixing this one will make Firefox behave like Chrome in this aspect, and currently it doesn't.

Comment 3

[David Durst [:ddurst]]

(In reply to Oriol Brufau [:Oriol] from comment #2)
> (In reply to Oriol Brufau [:Oriol] from comment #0)
> > would end up with an enabled browser action. This is not compatible with Chrome
> 
> It seems I didn't test Chrome properly.
> 
> Chrome returns the proper url, but that code ends up with an enabled browser
> action.
> 
> So in fact it's the opposite of what I thought. Fixing bug 1438274 without
> fixing this one will make Firefox behave like Chrome in this aspect, and
> currently it doesn't.

Following up, then, since bug 1438274 is now fixed, Firefox now behaves like Chrome in this aspect, correct?

Comment 4

[Oriol Brufau [:Oriol]]

Yes.