1438680 - Leanplum Banners Missing Some Functions in Firefox Nightly

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Settings and Preferences, defect, P3)

Description

[Jean Collings]

There are currently 2 issues with the banners when testing it on Nightly.

1) When you tap outside of the banner, the banner should disappear but that is not happening. 

Leanplum said that they fixed this issue and Nevin indicated that the updated SDK with this fix was integrated with LP, but maybe it has not? 


2) The banner blocks the keyboard when you click on an input field form or url bar.

Comment 1

[:sdaswani]

Barbara can you get this on your master prioritized list?

Comment 2

[Jean Collings]

You may have to reopen this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1390454 Since it wasn't really solved. Maybe the new SDK upgrade from Bug 1438716 will resolve it.

Comment 3

[Barbara Bermes [:barbara] - NI please!]

Highest priority to get done for 60

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Product team would like this fixed in 60, tracked as blocking to ensure it's closely monitored.

Comment 5

[Andrei Lazar]

Attachment: Bug 1438680: Merged changes from latest version of Leanplum SDK

(In reply to Barbara Bermes [:barbara] - NI please! from comment #3)
> Highest priority to get done for 60

I noticed a issue regarding updating Leanplum SDK https://bugzilla.mozilla.org/show_bug.cgi?id=1438716.
I can confirm that an upgrade of Leanplum SDK will fix the bug.
The issue was that the touch event was not properly dispatched.

Comment 6

[:sdaswani]

Andrei if you think a LP upgrade will fix a few issues, I have moved it to something to get into 60. Please upgrade the SDK.

Ritu, do you think a LP SDK upgrade will make the 60 uplift?

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding Julien, TomGrab so he can comment on the risk. The last time I was involved in LP SDK changes, was in 55 (I think) and I can mention two pre-requisites: 1) QA sign off (unless deemed unnecessary based on SDK scope changes) and 2) Security team review the SDK changes (PaulT).

Comment 8

[:sdaswani]

Andrei, can you post an attachment with the diff of the SDK code to give folks a sense of how significant the changes are and how much review would be needed?

Comment 9

[Andrei Lazar]

Attachment: Bug_1438716_Upgraded_Leanplum_SDK_to_v3_0_2_release.patch

I am currently working on upgrading the LP SDK to v3.0.2 (https://bugzilla.mozilla.org/show_bug.cgi?id=1438716) The process is cumbersome because the SDK is deeply integrated in the app and over the course of time has received various patches of ours which have to be ported to the new version. (The decision has been taken here https://bugzilla.mozilla.org/show_bug.cgi?id=1351585). I can provide a work in progress patch in order to provide more insight as to what this issue implies.

Comment 10

[:sdaswani]

Thanks Andrei - I think this means this work will not get into 60. That’s fine - I will start the process to get it integrated into 61.

Comment 11

[:sdaswani]

I have filed a PI request.

Comment 12

[Julien Cristau [:jcristau]]

Dropping the blocking status for 60 based on comment 10 and the dependency on an updated leanplum sdk.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Moving to p3 because no activity for at least 24 weeks.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 14

[Andrei Lazar]

Un-assigning myself from this since it got fixed upon upgrading the SDK.

Comment 15

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.