Closed Bug 1438680 Opened 5 years ago Closed 2 years ago

Leanplum Banners Missing Some Functions in Firefox Nightly

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect, P3)

Other
Android
defect

Tracking

(firefox60 wontfix, firefox61 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox60 --- wontfix
firefox61 --- affected

People

(Reporter: jcollings, Unassigned)

References

Details

(Whiteboard: [priority:medium])

Attachments

(2 files)

There are currently 2 issues with the banners when testing it on Nightly.

1) When you tap outside of the banner, the banner should disappear but that is not happening. 

Leanplum said that they fixed this issue and Nevin indicated that the updated SDK with this fix was integrated with LP, but maybe it has not? 


2) The banner blocks the keyboard when you click on an input field form or url bar.
Barbara can you get this on your master prioritized list?
Flags: needinfo?(bbermes)
You may have to reopen this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1390454 Since it wasn't really solved. Maybe the new SDK upgrade from Bug 1438716 will resolve it.
Highest priority to get done for 60
Flags: needinfo?(bbermes)
Whiteboard: [Leanplum] → [Leanplum] [60]
Product team would like this fixed in 60, tracked as blocking to ensure it's closely monitored.
Assignee: nobody → andrei.a.lazar
(In reply to Barbara Bermes [:barbara] - NI please! from comment #3)
> Highest priority to get done for 60

I noticed a issue regarding updating Leanplum SDK https://bugzilla.mozilla.org/show_bug.cgi?id=1438716.
I can confirm that an upgrade of Leanplum SDK will fix the bug.
The issue was that the touch event was not properly dispatched.
Andrei if you think a LP upgrade will fix a few issues, I have moved it to something to get into 60. Please upgrade the SDK.

Ritu, do you think a LP SDK upgrade will make the 60 uplift?
Flags: needinfo?(rkothari)
Adding Julien, TomGrab so he can comment on the risk. The last time I was involved in LP SDK changes, was in 55 (I think) and I can mention two pre-requisites: 1) QA sign off (unless deemed unnecessary based on SDK scope changes) and 2) Security team review the SDK changes (PaulT).
Flags: needinfo?(tgrabowski)
Flags: needinfo?(rkothari)
Flags: needinfo?(ptheriault)
Flags: needinfo?(jcristau)
Andrei, can you post an attachment with the diff of the SDK code to give folks a sense of how significant the changes are and how much review would be needed?
Flags: needinfo?(andrei.a.lazar)
I am currently working on upgrading the LP SDK to v3.0.2 (https://bugzilla.mozilla.org/show_bug.cgi?id=1438716) The process is cumbersome because the SDK is deeply integrated in the app and over the course of time has received various patches of ours which have to be ported to the new version. (The decision has been taken here https://bugzilla.mozilla.org/show_bug.cgi?id=1351585). I can provide a work in progress patch in order to provide more insight as to what this issue implies.
Flags: needinfo?(andrei.a.lazar)
Thanks Andrei - I think this means this work will not get into 60. That’s fine - I will start the process to get it integrated into 61.
Flags: needinfo?(tgrabowski)
Flags: needinfo?(sdaswani)
Flags: needinfo?(ptheriault)
Flags: needinfo?(jcristau)
I have filed a PI request.
Flags: needinfo?(sdaswani)
Depends on: 1438716
Whiteboard: [Leanplum] [60] → [Leanplum] [61]
Dropping the blocking status for 60 based on comment 10 and the dependency on an updated leanplum sdk.
Whiteboard: [Leanplum] [61] → [priority:medium]
Moving to p3 because no activity for at least 24 weeks.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P1 → P3

Un-assigning myself from this since it got fixed upon upgrading the SDK.

Assignee: andrei.a.lazar → nobody
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.