1438691 - Build a quick-and-dirty way of detecting when privileged framescripts access things outside of the top-level document compartment

Status: RESOLVED INVALID

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Summary says it all. This is to help get a sense of what things might need to change when we have site isolation enabled.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1438691 - [Please never land this] Tripwire observer notifications

Quick-and-dirty hack that tries to notice when privileged JS attempts to
access things outside of the top-level document compartment. There's a
WebExtension that goes along with this.

Review commit: https://reviewboard.mozilla.org/r/220754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220754/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

My add-on, which I've dramatically named "Tripwire", is a two-parter: an "experiment" Tripwire API that lets it monitor the messages coming from the content processes regarding violations, and the WebExtension which just adds a simple front-end.

Both of these depend on the patch in this bug to work.

https://github.com/mikeconley/tripwire-api
https://github.com/mikeconley/tripwire

I'm not 100% certain that what's being reported is accurate yet, but it's a start.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey jryans,

ehsan said you might find this useful. Maybe. I'm not sure.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks, I'll check it out!  As another variation, I've been using :mystor's WIP hack for remote frames (bug 1429896) and looking around for what breaks.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I think this bug has served it's purpose for our investigation.