Closed
Bug 1438697
Opened 6 years ago
Closed 6 years ago
Add chrome-only attribute to page transition events during frame swaps
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file)
During frame swaps, we send pagehide / pageshow events that resemble what happens on reload. For DevTools, this results in confusing results in wasted effort as we assume the page is actually going away, which is untrue for the frame swap case. Let's add a chrome-only attribute to these events so we can distinguish this case.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•6 years ago
|
||
(Meant to write a better commit message, will update...)
| Comment hidden (mozreview-request) |
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951743 [details] Bug 1438697 - Add inFrameSwap property on page transition. https://reviewboard.mozilla.org/r/221016/#review227688 This seems reasonable.
Attachment #8951743 -
Flags: review?(mrbkap) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7bf586044674 Add inFrameSwap property on page transition. r=mrbkap
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7bf586044674
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•