1438707 - More minor XPT cleanups

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 1 - C++ize the XPT modelines.

These are C++ files now. This makes it so the highlighting works if
you use classes, etc.

Review commit: https://reviewboard.mozilla.org/r/220944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220944/

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 2 - Rename CHECK_COUNT to CheckCount.

This isn't a macro, so rename it.

Review commit: https://reviewboard.mozilla.org/r/220946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220946/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 3 - De-macroize CURS_POINT.

Review commit: https://reviewboard.mozilla.org/r/220948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220948/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 4 - De-macroize more XPT stuff.

Review commit: https://reviewboard.mozilla.org/r/220950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220950/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 5 - Replace XPT_ASSERT with MOZ_ASSERT.

Review commit: https://reviewboard.mozilla.org/r/220952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220952/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438707, part 6 - Remove nsXPTConstant.

It is unused.

Review commit: https://reviewboard.mozilla.org/r/220954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220954/

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 8951656 [details]
Bug 1438707, part 1 - C++ize the XPT modelines.

https://reviewboard.mozilla.org/r/220944/#review226982

Bonus points if you add the vim modeline to each file:

/* vim: set ts=8 sts=4 et sw=4 tw=80: */

Comment 8

[Nicholas Nethercote [inactive]]

Comment on attachment 8951657 [details]
Bug 1438707, part 2 - Rename CHECK_COUNT to CheckCount.

https://reviewboard.mozilla.org/r/220946/#review226984

Comment 9

[Nicholas Nethercote [inactive]]

Comment on attachment 8951658 [details]
Bug 1438707, part 3 - De-macroize CURS_POINT.

https://reviewboard.mozilla.org/r/220948/#review226988

Comment 10

[Nicholas Nethercote [inactive]]

Comment on attachment 8951659 [details]
Bug 1438707, part 4 - De-macroize more XPT stuff.

https://reviewboard.mozilla.org/r/220950/#review226990

Much nicer.

Comment 11

[Nicholas Nethercote [inactive]]

Comment on attachment 8951661 [details]
Bug 1438707, part 6 - Remove nsXPTConstant.

https://reviewboard.mozilla.org/r/220954/#review226994

Comment 12

[Nicholas Nethercote [inactive]]

Comment on attachment 8951660 [details]
Bug 1438707, part 5 - Replace XPT_ASSERT with MOZ_ASSERT.

https://reviewboard.mozilla.org/r/220952/#review226992

Nice.

Comment 13

[Andrew McCreight [:mccr8]]

Comment on attachment 8951656 [details]
Bug 1438707, part 1 - C++ize the XPT modelines.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220944/diff/1-2/

Comment 14

[Andrew McCreight [:mccr8]]

Comment on attachment 8951657 [details]
Bug 1438707, part 2 - Rename CHECK_COUNT to CheckCount.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220946/diff/1-2/

Comment 15

[Andrew McCreight [:mccr8]]

Comment on attachment 8951658 [details]
Bug 1438707, part 3 - De-macroize CURS_POINT.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220948/diff/1-2/

Comment 16

[Andrew McCreight [:mccr8]]

Comment on attachment 8951659 [details]
Bug 1438707, part 4 - De-macroize more XPT stuff.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220950/diff/1-2/

Comment 17

[Andrew McCreight [:mccr8]]

Comment on attachment 8951660 [details]
Bug 1438707, part 5 - Replace XPT_ASSERT with MOZ_ASSERT.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220952/diff/1-2/

Comment 18

[Andrew McCreight [:mccr8]]

Comment on attachment 8951661 [details]
Bug 1438707, part 6 - Remove nsXPTConstant.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220954/diff/1-2/

Comment 19

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #7)
> Bonus points if you add the vim modeline to each file:

Done.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e096038bd58
part 1 - C++ize the XPT modelines. r=njn
https://hg.mozilla.org/integration/autoland/rev/31a3d9ae3ed1
part 2 - Rename CHECK_COUNT to CheckCount. r=njn
https://hg.mozilla.org/integration/autoland/rev/e6734d35011c
part 3 - De-macroize CURS_POINT. r=njn
https://hg.mozilla.org/integration/autoland/rev/eaddf501ff6a
part 4 - De-macroize more XPT stuff. r=njn
https://hg.mozilla.org/integration/autoland/rev/6e3cc809579c
part 5 - Replace XPT_ASSERT with MOZ_ASSERT. r=njn
https://hg.mozilla.org/integration/autoland/rev/b80453dc653f
part 6 - Remove nsXPTConstant. r=njn

Comment 21

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9e096038bd58
https://hg.mozilla.org/mozilla-central/rev/31a3d9ae3ed1
https://hg.mozilla.org/mozilla-central/rev/e6734d35011c
https://hg.mozilla.org/mozilla-central/rev/eaddf501ff6a
https://hg.mozilla.org/mozilla-central/rev/6e3cc809579c
https://hg.mozilla.org/mozilla-central/rev/b80453dc653f