Closed Bug 1438707 Opened 4 years ago Closed 4 years ago

More minor XPT cleanups

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(6 files)

No description provided.
Comment on attachment 8951656 [details]
Bug 1438707, part 1 - C++ize the XPT modelines.

https://reviewboard.mozilla.org/r/220944/#review226982

Bonus points if you add the vim modeline to each file:

/* vim: set ts=8 sts=4 et sw=4 tw=80: */
Attachment #8951656 - Flags: review?(n.nethercote) → review+
Comment on attachment 8951657 [details]
Bug 1438707, part 2 - Rename CHECK_COUNT to CheckCount.

https://reviewboard.mozilla.org/r/220946/#review226984
Attachment #8951657 - Flags: review?(n.nethercote) → review+
Comment on attachment 8951658 [details]
Bug 1438707, part 3 - De-macroize CURS_POINT.

https://reviewboard.mozilla.org/r/220948/#review226988
Attachment #8951658 - Flags: review?(n.nethercote) → review+
Comment on attachment 8951659 [details]
Bug 1438707, part 4 - De-macroize more XPT stuff.

https://reviewboard.mozilla.org/r/220950/#review226990

Much nicer.
Attachment #8951659 - Flags: review?(n.nethercote) → review+
Comment on attachment 8951661 [details]
Bug 1438707, part 6 - Remove nsXPTConstant.

https://reviewboard.mozilla.org/r/220954/#review226994
Attachment #8951661 - Flags: review?(n.nethercote) → review+
Comment on attachment 8951660 [details]
Bug 1438707, part 5 - Replace XPT_ASSERT with MOZ_ASSERT.

https://reviewboard.mozilla.org/r/220952/#review226992

Nice.
Attachment #8951660 - Flags: review?(n.nethercote) → review+
(In reply to Nicholas Nethercote [:njn] from comment #7)
> Bonus points if you add the vim modeline to each file:

Done.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e096038bd58
part 1 - C++ize the XPT modelines. r=njn
https://hg.mozilla.org/integration/autoland/rev/31a3d9ae3ed1
part 2 - Rename CHECK_COUNT to CheckCount. r=njn
https://hg.mozilla.org/integration/autoland/rev/e6734d35011c
part 3 - De-macroize CURS_POINT. r=njn
https://hg.mozilla.org/integration/autoland/rev/eaddf501ff6a
part 4 - De-macroize more XPT stuff. r=njn
https://hg.mozilla.org/integration/autoland/rev/6e3cc809579c
part 5 - Replace XPT_ASSERT with MOZ_ASSERT. r=njn
https://hg.mozilla.org/integration/autoland/rev/b80453dc653f
part 6 - Remove nsXPTConstant. r=njn
You need to log in before you can comment on or make changes to this bug.