Closed Bug 1438730 Opened 2 years ago Closed Last year

[wpt-sync] PR 9553 - [css-grid] Baseline alignment inside the tracks sizing algorithm

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

We have identified several cases where the Baseline Alignment accounts
for the grid's intrinsic size. Since we depend on the track sizing
algorithm to compute the grid's intrinsic size, the only way to handle
all these cases is to integrate the baseline alignment logic in the
algorithm.

Additionally, the CSSWG has identified several cases that can't be
solved properly; such cases have in common that they imply cyclic
dependencies between the item's and grid area's size. The CSSWG has
resolved that these items don't participate in baseline alignment:

https://github.com/w3c/csswg-drafts/issues/1365

There are also other related issues with some examples and relevant
discussions about this topic:

https://github.com/w3c/csswg-drafts/issues/1039
https://github.com/w3c/csswg-drafts/issues/1409

Bug: 704713
Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22

Reviewed-on: https://chromium-review.googlesource.com/923261
WPT-Export-Revision: 26ec2255dea7260dedaf0887d2ca550e3e8414bf
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 10 tests and 55 subtests
OK     : 10
PASS   : 2
FAIL   : 53

New tests that have failures or other problems:
/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-001.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-002.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-004.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004.html
    .inline-grid 1: FAIL
    .inline-grid 2: FAIL
    .inline-grid 3: FAIL
    .inline-grid 4: FAIL
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html
    .inline-grid 10: FAIL
    .inline-grid 2: FAIL
    .inline-grid 3: FAIL
    .inline-grid 4: FAIL
    .inline-grid 6: FAIL
    .inline-grid 7: FAIL
    .inline-grid 8: FAIL
    .inline-grid 9: FAIL
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html
    .inline-grid 1: FAIL
    .inline-grid 10: FAIL
    .inline-grid 11: FAIL
    .inline-grid 12: FAIL
    .inline-grid 13: FAIL
    .inline-grid 14: FAIL
    .inline-grid 15: FAIL
    .inline-grid 16: FAIL
    .inline-grid 2: FAIL
    .inline-grid 3: FAIL
    .inline-grid 4: FAIL
    .inline-grid 5: FAIL
    .inline-grid 6: FAIL
    .inline-grid 7: FAIL
    .inline-grid 8: FAIL
    .inline-grid 9: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00d30e4a6158
[wpt PR 9553] - [css-grid] Baseline alignment inside the tracks sizing algorithm, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb519193b813
[wpt PR 9553] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/00d30e4a6158
https://hg.mozilla.org/mozilla-central/rev/fb519193b813
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.