1438742 - Failure Classification panel needs to cancel loading when another job is selected

Status: RESOLVED INVALID

(Tree Management :: Treeherder: Frontend, defect)

Description

[Phil Ringnalda (:philor)]

This is something we did years ago for the Failure Summary panel, but Classification doesn't have it.

You need a particular set of failures to see it, but luckily it's a common set (a wpt job as failure 2 generally works well, since most of the chunks have a half dozen or more false-positive crashes). Given failure 1 which is selected, failure 2 which has enough lines to take a little while to load, and failure 3 which has only one failure line, type N to select failure 2, and then before the Failure Classification panel loads, type N again to select failure 3. The single line of 3 will load, but then the load of failure 2 that you triggered on your way by will finish loading and replace 3's content, or maybe shove itself up above 3's content, I'm not quite sure. I have seen the related case, where you classify failure 2, but then hit N before the Failure Classification panel has enough time to load its display of how you classified it, where you wind up with failure 3's unclassified failure line, and then down below that the classified failure lines from failure 2, so maybe I just don't notice that whenever you hit this, both 2 and 3 have their failure lines shown.

At this point, I suspect that if you go ahead and classify with 3 selected but with the failure lines from 2, what you do is classify 3. That strikes me as a possible explanation for the otherwise inexplicable bug 1389799 - someone starring "devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out" (which had a perfectly-matched suggestion already) with the obviously totally unrelated "Intermittent browser/components/sessionstore/test/browser_upgrade_backup.js | upgrade backup should be set - Got , expected 20180202165238" makes no sense, but someone seeing the failure line which matches that second bug while having a selected job which actually had the first one does make sense.

Comment 1

[Cameron Dawson [:camd]]

We are removing the Failure Classification panel soon in lieu of other approaches.