Closed
Bug 1438750
Opened 6 years ago
Closed 6 years ago
Remove mfbt/double-conversion.h, and change existing users to instead do #include "double-conversion/double-conversion.h" themselves
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
7.06 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Followup to bug 1402344 from awhile back.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8951505 -
Flags: review?(nfroyd)
|
||
Updated•6 years ago
|
Attachment #8951505 -
Flags: review?(nfroyd) → review+
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/66c1c1596bea Remove mfbt/double-conversion.h, and change existing users to instead do #include "double-conversion/double-conversion.h" themselves. r=froydnj
Backout by rgurzau@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/39518a5011af Backed out changeset 66c1c1596bea for assertion failure at TestFloatingPoint.cpp on Windows platform
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/84214cf75b88 Remove mfbt/double-conversion.h, and change existing users to instead do #include "double-conversion/double-conversion.h" themselves. r=froydnj on a CLOSED TREE
|
||
Comment 5•6 years ago
|
||
Please ignore comment comment #3 as we backed out the incorrect changeset for the TestFloatingPoint.exe test failures. Will comment on that bug.
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/84214cf75b88
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•