Closed Bug 1438757 Opened 6 years ago Closed 6 years ago

[wpt-sync] PR 9555 - service worker: Disallow interception for EMBED and OBJECT requests.

Categories

(Core :: DOM: Service Workers, enhancement, P3)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

This matches the service worker specification and Firefox.

This change itself is probably not enough to skip all EMBED/OBJECT
requests, as some requests get initiated by PepperURLLoaderHost or
MimeHandlerViewContainer.

In implementor concerns:
https://w3c.github.io/ServiceWorker/#implementer-concerns
"Plug-ins should not load via service workers. As plug-ins may get their
security origins from their own urls, the embedding service worker cannot
handle it. For this reason, the Handle Fetch algorithm makes the
potential-navigation-or-subresource request (whose context is either <embed> or
<object>) immediately fallback to the network without dispatching fetch event."

In Handle Fetch:
https://w3c.github.io/ServiceWorker/#handle-fetch
"If request is a potential-navigation-or-subresource request, then:
Return null."


R=kinuko, yhirano

Bug: 771933
Change-Id: Ia04ae8dec8c968de6a73dca088aa88a67b21718a

Reviewed-on: https://chromium-review.googlesource.com/923445
WPT-Export-Revision: 4aaa6a594e9fd61b45fc35b9ba669fdbfa0224e3
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Ran 1 tests and 4 subtests
OK     : 1
PASS   : 4
Priority: -- → P3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ea36f915539
[wpt PR 9555] - service worker: Disallow interception for EMBED and OBJECT requests., a=testonly
https://hg.mozilla.org/mozilla-central/rev/0ea36f915539
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.