1438763 - Intermittent browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Uncaught exception - at browser_undo_notification_multiple_dismissal.js:83 - TypeError: Argument 1 of MutationObserver.observe is not an object.

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=162454339&repo=autoland

https://queue.taskcluster.net/v1/task/BawOke1CTI6OtgX14-7zrg/runs/0/artifacts/public/logs/live_backing.log

09:07:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:83 - TypeError: Argument 1 of MutationObserver.observe is not an object.
09:07:56     INFO - Stack trace:
09:07:56     INFO -     checkNotificationsDismissed/firstTabNotificationRemovedPromise<@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:83:5
09:07:56     INFO -     checkNotificationsDismissed@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:57:44
09:07:56     INFO -     Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1067:21
09:07:56     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
09:07:56     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
09:07:56     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
09:07:56     INFO - Leaving test bound checkNotificationsDismissed
09:07:56     INFO - GECKO(969) | [Child 973, Main Thread] WARNING: attempt to modify an immutable nsStandardURL: file /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.cpp, line 1698
09:07:56     INFO - GECKO(969) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
09:07:56     INFO - GECKO(969) | MEMORY STAT | vsize 4134MB | residentFast 300MB | heapAllocated 111MB
09:07:56     INFO - TEST-OK | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | took 3146ms
09:07:56     INFO - Not taking screenshot here: see the one that was previously logged
09:07:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Found an unexpected tab at the end of test run: about:home - 
09:07:56     INFO - Not taking screenshot here: see the one that was previously logged
09:07:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Found an unexpected tab at the end of test run: about:home - 
09:07:56     INFO - GECKO(969) | ++DOCSHELL 0x1223e3000 == 3 [pid = 970] [id = {bd068162-7923-8147-a868-12ec84ed6518}]
09:07:56     INFO - GECKO(969) | ++DOMWINDOW == 8 (0x114b78f90) [pid = 970] [serial = 8] [outer = 0x0]
09:07:56     INFO - GECKO(969) | ++DOMWINDOW == 9 (0x12391ec00) [pid = 970] [serial = 9] [outer = 0x114b78f90]

Comment 1

[Natalia Csoregi [:nataliaCs]]

occurs on browser-chrome tests as well https://treeherder.mozilla.org/logviewer.html#?job_id=162762466&repo=mozilla-central&lineNumber=11756

Comment 2

[Intermittent Failures Robot]

9 failures in 685 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 4
* autoland: 4
* mozilla-inbound: 1

Platform breakdown:
* linux64: 5
* windows10-64-ccov: 3
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438763&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 3

[Intermittent Failures Robot]

20 failures in 675 pushes (0.03 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 11
* autoland: 7
* mozilla-inbound: 2

Platform breakdown:
* linux64: 15
* windows10-64-ccov: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438763&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 4

[Stefan Hindli [:stefan_hindli]]

There are 31 failures on this bug over the last 7 days. These happen on Linux x64 and windows10-64-ccov

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=165689012&lineNumber=3265

Here is a relevant part of that log: 

[task 2018-03-03T00:14:25.663Z] 00:14:25     INFO - Buffered messages finished
[task 2018-03-03T00:14:25.664Z] 00:14:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:83 - TypeError: Argument 1 of MutationObserver.observe is not an object.
[task 2018-03-03T00:14:25.665Z] 00:14:25     INFO - Stack trace:
[task 2018-03-03T00:14:25.667Z] 00:14:25     INFO -     checkNotificationsDismissed/firstTabNotificationRemovedPromise<@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:83:5
[task 2018-03-03T00:14:25.668Z] 00:14:25     INFO -     checkNotificationsDismissed@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:57:44
[task 2018-03-03T00:14:25.669Z] 00:14:25     INFO -     Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1067:21
[task 2018-03-03T00:14:25.670Z] 00:14:25     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
[task 2018-03-03T00:14:25.671Z] 00:14:25     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
[task 2018-03-03T00:14:25.672Z] 00:14:25     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-03-03T00:14:25.681Z] 00:14:25     INFO - Leaving test bound checkNotificationsDismissed
[task 2018-03-03T00:14:25.684Z] 00:14:25     INFO - GECKO(2324) | MEMORY STAT | vsize 20973873MB | residentFast 1046MB
[task 2018-03-03T00:14:25.686Z] 00:14:25     INFO - TEST-OK | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | took 3210ms
[task 2018-03-03T00:14:25.688Z] 00:14:25     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-03-03T00:14:25.695Z] 00:14:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Found an unexpected tab at the end of test run: about:home - 
[task 2018-03-03T00:14:25.698Z] 00:14:25     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-03-03T00:14:25.699Z] 00:14:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js | Found an unexpected tab at the end of test run: about:home - 
[task 2018-03-03T00:14:25.701Z] 00:14:25     INFO - checking window state
[task 2018-03-03T00:14:25.703Z] 00:14:25     INFO - TEST-START | browser/components/migration/tests/browser/browser_undo_notification_wording.js
[task 2018-03-03T00:14:26.116Z] 00:14:26     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-03-03T00:14:26.117Z] 00:14:26     INFO - Buffered messages logged at 00:14:25
[task 2018-03-03T00:14:26.118Z] 00:14:26     INFO - Entering test bound autoMigrationUndoNotificationShows
[task 2018-03-03T00:14:26.118Z] 00:14:26     INFO - Buffered messages finished
[task 2018-03-03T00:14:26.119Z] 00:14:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_undo_notification_wording.js | uncaught exception - ReferenceError: ok is not defined at obs@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_undo_notification_multiple_dismissal.js:91:7

Comment 5

[Matthew N. [:MattN]]

Redirecting to Gijs since he wrote this test and reviewed the last test-specific change.

Comment 6

[Intermittent Failures Robot]

34 failures in 831 pushes (0.041 failures/push) were associated with this bug in the last 7 days.   

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 11
* try: 8
* mozilla-central: 8
* autoland: 7

Platform breakdown:
* linux64: 28
* windows10-64-ccov: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438763&startday=2018-02-26&endday=2018-03-04&tree=all

Comment 7

[:Gijs (he/him)]

I will try to look at this when I have time.

However, :jmaher, it looks like this orange is basically all TV orange. That means lots of orange and 'hits' for the intermittent when the test is touched and then... crickets. Until the test is next touched. It doesn't look like the stockwell / orangefactor robot setup currently works well for this, because it overstates the case for a bug one week and will then understate it the next week (when, effectively, nothing has changed but the test just hasn't been touched that week). Is there a bug on file for dealing with this?

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs (under the weather; responses will be slow) from comment #7)
> I will try to look at this when I have time.
> 
> However, :jmaher, it looks like this orange is basically all TV orange. That
> means lots of orange and 'hits' for the intermittent when the test is
> touched and then... crickets. Until the test is next touched. It doesn't
> look like the stockwell / orangefactor robot setup currently works well for
> this, because it overstates the case for a bug one week and will then
> understate it the next week (when, effectively, nothing has changed but the
> test just hasn't been touched that week). Is there a bug on file for dealing
> with this?

... oh, except the summary is misleading and there's only been 1 test-verify instance starred and there are dozens of non-test-verify hits. Well, never mind then!

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

the failures here are linux64-asan and windows10-ccov.  ccov is really slow- think a debug build and then slow it down again.  linux64-asan is slow of course- this could be a timing issue?

otherwise this is the same pattern as we see in the original comment.  This tells me that this issue was caught in test-verify and now it is showing up regularly in other configs.

Comment 10

[:Gijs (he/him)]

Attachment: Bug 1438763 - fix intermittent orange in undo_notification_multiple_dismissal.js,

When bug 1433324 made these tests run against activity stream, it made the notification
fire from the test's head.js file itself. Unfortunately, that races with the new tab / home
page actually loading, triggering an `onLocationChange` event in the tabbrowser, which
removes the notification again, meaning it is then no longer there when the test expects
it to be.

This wasn't an issue before, because the notification bar was opened via a message from
within the new tab page, which always arrived after the `onLocationChange` event.

Because the current state is temporary anyway, I'm just changing the test to open 2 tabs
first, and then opening the notification bars, which in practice guarantees this happens
after the `onLocationChange` event.

Review commit: https://reviewboard.mozilla.org/r/225808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225808/

Comment 11

[Ursula Sarracini (:ursula)]

Comment on attachment 8956858 [details]
Bug 1438763 - fix intermittent orange in undo_notification_multiple_dismissal.js,

https://reviewboard.mozilla.org/r/225808/#review231704

Makes sense. Thanks Gijs!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c6aad9d610f
fix intermittent orange in undo_notification_multiple_dismissal.js, r=ursula

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2c6aad9d610f

Comment 14

[Intermittent Failures Robot]

10 failures in 747 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 5
* try: 2
* mozilla-inbound: 2
* mozilla-central: 1

Platform breakdown:
* linux64: 9
* windows10-64-ccov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438763&startday=2018-03-05&endday=2018-03-11&tree=all