Closed Bug 1438778 Opened 4 years ago Closed 3 years ago

Intermittent devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js | Test timed out -

Categories

(DevTools :: Debugger, defect, P5)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other]) 

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=162515555&repo=try

https://queue.taskcluster.net/v1/task/f9QkQfRJSimWTavPDRjL4Q/runs/0/artifacts/public/logs/live_backing.log

13:18:47     INFO - Toolbox opened and focused
13:18:47     INFO - test opening and closing
13:18:47     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js | quickOpen enabled - 
13:18:47     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js | quickOpen disabled - 
13:18:47     INFO - Waiting for state change: 
13:18:47     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js | quickOpen enabled - 
13:18:47     INFO - Waiting for state change: selected source
13:18:47     INFO - Buffered messages finished
13:18:47     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js | Test timed out -
Product: Firefox → DevTools
In the last 7 days, there are 47 failures associated with this bug.

They occur on linux32 (opt), linux64 (pgo, asan, debug, opt), osx-10-10 (opt, debug).

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195461284&repo=autoland&lineNumber=4210

:jlast, Could you please have a look at this?
Flags: needinfo?(jlaster)
Whiteboard: [stockwell needswork]
Okay, happy to look. I just tried to reproduce locally and couldn't but I can see where it is happening and will investigate soon

by the way, it was introduced in 84 i believe - https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2018-08-16&endday=2018-08-23&tree=trunk&bug=1438778


```
diff --git a/src/test/mochitest/browser_dbg-quick-open.js b/src/test/mochitest/browser_dbg-quick-open.js
index 2807c90..062aa59 100644
--- a/src/test/mochitest/browser_dbg-quick-open.js
+++ b/src/test/mochitest/browser_dbg-quick-open.js
@@ -65,6 +65,10 @@ add_task(async function() {
   await waitForSource(dbg, "switching-01");
   quickOpen(dbg, "sw");
   pressKey(dbg, "Enter");
+
+  // it fails to open this source.. i wonder if it is one of two things
+  // 1. it tries to select that source and doesnt load
+  // 2. it tries to select switching-02
   await waitForSelectedSource(dbg, "switching-01");

   info("Arrow keys and check to see if source is selected");
(END)
```
Flags: needinfo?(jlaster)
There is this error in the log, but it doesn't seem relevant:

https://treeherder.mozilla.org/logviewer.html#?job_id=196019032&repo=mozilla-inbound&lineNumber=6161

Console message: [JavaScript Error: "NetworkError when attempting to fetch resource."]
get@resource://services-settings/remote-settings.js:326:9
async*getSite@resource://activity-stream/lib/FaviconFeed.jsm:158:25
async*fetchIcon@resource://activity-stream/lib/FaviconFeed.jsm:132:24
async*onAction@resource://activity-stream/lib/FaviconFeed.jsm:182:9
_middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
_requestRichIcon@resource://activity-stream/lib/TopSitesFeed.jsm:461:5
_fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:425:5
async*getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:330:11
async*refresh@resource://activity-stream/lib/TopSitesFeed.jsm:353:25
async*onAction@resource://activity-stream/lib/TopSitesFeed.jsm:653:9
_middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
init/this.intervalId<@resource://activity-stream/lib/SystemTickFeed.jsm:18:41
notify@resource://gre/modules/Timer.jsm:42:7
Please don't disable :) I'll look into a fix soon.
with bug 956376 patch applied (which increases the chance of timeout. might be different issue tho), what I confirmed is, switching-02 is shown *before* switching-01 in the dropdown list.

is the order in the listbox supposed to be fixed? (like, alphabetically sorted?)
if not, I think the test should type "switching-01", instead of "sw", to avoid listing both sources.
Flags: needinfo?(arai.unmht) → needinfo?(jlaster)
Blocks: 956376
This will fix it
https://github.com/devtools-html/debugger.html/pull/6924
Flags: needinfo?(jlaster)
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:other]
the change seems to be merged, but still the drop down menu shows switching-02 first for me, after bug 956376 patch applied, and it fails at the first `await waitForSelectedSource(dbg, "switching-01");`
do you know how the list items are ordered?
Flags: needinfo?(jlaster)
hmm, i'm not really sure. I think it is sorted by order of appearance initially and when you type by fuzz-aldrin
Flags: needinfo?(jlaster)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.