1438780 - Sometimes bookmarks folder gets deleted after Firefox is killed from task manager

Status: UNCONFIRMED

(Firefox :: Bookmarks & History, enhancement, P5)

Description

[In]

Is happened thrice to me and the folders were not created in that session.

Comment 1

[Marco Bonardo [:mak]]

By closed from task manager, do you mean killed?
If you kill the process, it's possible that the latest bookmarks are not written yet, that's what preserves the database coherency.

If it's not bookmarks created in that session, I can guess a couple reasons:
1. Sync may have some problems with the other devices and maybe it's moving the contents of that folder to unfiled, maybe you're killing the process in the middle of sync operations
2. you may have some corruption problem to the database, maybe due to disk or memory issues in the system, killing the process is more likely to hit those corruptions.

For now please try to run the Places maintenance button from about:support and report the output here.

Comment 2

[In]

(In reply to Marco Bonardo [::mak] from comment #1)
> For now please try to run the Places maintenance button from about:support
> and report the output here.
Do you mean about:support/Places Database/Integrity/Verify Integrity?

Comment 3

[In]

(In reply to Marco Bonardo [::mak] from comment #1)
> If it's not bookmarks created in that session, I can guess a couple reasons:
> 1. Sync may have some problems with the other devices and maybe it's moving
> the contents of that folder to unfilled, maybe you're killing the process in
> the middle of sync operations
Is it a problem with Sync?

Comment 4

[Marco Bonardo [:mak]]

(In reply to In from comment #2)
> Do you mean about:support/Places Database/Integrity/Verify Integrity?

yes

(In reply to In from comment #3)
> Is it a problem with Sync?

It is a problem in general, no app can gracefully handle being killed abruptly, that's why they have a close button that can do things properly. Apps just try to limit dataloss as far as possible, but they can't predict when and if the process may be killed.

Comment 5

[In]

(In reply to Marco Bonardo [::mak] from comment #4)
If I-
1. shutdown Windows(7) without closing Firefox/
2. firefox crash/
3. "Program not reponding" windows diogol box asking to End Process
will the be same thing happen(as if I would have closed it from task manager)?

Comment 6

[Marco Bonardo [:mak]]

(In reply to In from comment #5)
> (In reply to Marco Bonardo [::mak] from comment #4)
> If I-
> 1. shutdown Windows(7) without closing Firefox/
> 2. firefox crash/
> 3. "Program not reponding" windows diogol box asking to End Process
> will the be same thing happen(as if I would have closed it from task
> manager)?

if it's not responding there's something broken at the profile level. You should try a profile reset.
crashing on shutdown is similar but slightly better since it's likely most of the components have shutdown properly before the crash (we crash after 1 minute).

Comment 7

[Marco Bonardo [:mak]]

Did you have a chance to run Integrity? What's the result?

Comment 8

[In]

> Task: checkIntegrity
+ The database is sane
> Task: invalidateCaches
+ The caches have been invalidated
> Task: checkCoherence
+ The database is coherent
> Task: expire
+ Database cleaned up
> Task: vacuum
+ Initial database size is 10240 KiB
+ The database has been vacuumed
+ Final database size is 10240 KiB
> Task: stats
+ Database size is 10240 KiB
+ pragma_user_version is 41
+ pragma_page_size is 32768
+ pragma_cache_size is -2048
+ pragma_journal_mode is wal
+ pragma_synchronous is 1
+ History can store a maximum of 97974 unique pages
+ Table moz_places has 13967 records
+ Table moz_historyvisits has 100 records
+ Table moz_inputhistory has 105 records
+ Table moz_hosts has 2457 records
+ Table moz_bookmarks has 17120 records
+ Table moz_bookmarks_deleted has 0 records
+ Table moz_keywords has 0 records
+ Table sqlite_sequence has 0 records
+ Table moz_anno_attributes has 9 records
+ Table moz_annos has 1505 records
+ Table moz_items_annos has 2170 records
+ Table sqlite_stat1 has 17 records
+ Index sqlite_autoindex_moz_inputhistory_1
+ Index sqlite_autoindex_moz_hosts_1
+ Index sqlite_autoindex_moz_bookmarks_deleted_1
+ Index sqlite_autoindex_moz_keywords_1
+ Index sqlite_autoindex_moz_anno_attributes_1
+ Index moz_places_url_hashindex
+ Index moz_places_hostindex
+ Index moz_places_visitcount
+ Index moz_places_frecencyindex
+ Index moz_places_lastvisitdateindex
+ Index moz_places_guid_uniqueindex
+ Index moz_historyvisits_placedateindex
+ Index moz_historyvisits_fromindex
+ Index moz_historyvisits_dateindex
+ Index moz_bookmarks_itemindex
+ Index moz_bookmarks_parentindex
+ Index moz_bookmarks_itemlastmodifiedindex
+ Index moz_bookmarks_guid_uniqueindex
+ Index moz_keywords_placepostdata_uniqueindex
+ Index moz_annos_placeattributeindex
+ Index moz_items_annos_itemattributeindex
+ Index moz_bookmarks_dateaddedindex
> Task: _refreshUI

Comment 9

[Marco Bonardo [:mak]]

I don't have further ideas, apart from the fact you should in general avoid to kill a process without using the common X/Close, and check the health status of your RAM/HDD.
P5 for now, will reprioritize if we get any interesting details about this behavior.

Comment 10

[mozillatester1]

(In reply to Marco Bonardo [::mak] from comment #9)
> I don't have further ideas, apart from the fact you should in general avoid
> to kill a process without using the common X/Close, and check the health
> status of your RAM/HDD.
> P5 for now, will reprioritize if we get any interesting details about this
> behavior.

Firefox never seems to warn me when closing Firefox.

Comment 11

[mozillatester1]

If I-
1. shutdown Windows(7) without closing Firefox/
2. firefox crash/
3. "Program not reponding" windows diogol box asking to End Process
will the be same thing happen(as if I would have closed it from task manager)?

Comment 12

[Marco Bonardo [:mak]]

(In reply to mozillatester1 from comment #11)
> If I-
> 1. shutdown Windows(7) without closing Firefox/
> 2. firefox crash/
> 3. "Program not reponding" windows diogol box asking to End Process
> will the be same thing happen(as if I would have closed it from task
> manager)?

Yes.
If you close Windows before Firefox, ideally Firefox should block shutdown for a minute, then give up and eventually crash. But you could also force shutdown from the windows dialog asking if you want to proceed anyway. In both cases it's pretty much the same as a crash, and due to our performance choices a crash can always lose the last uncommitted transactions.

In most cases that minute is enough for Firefox to just do its work and let Windows shutdown without any loss, so it's possible in your profile there's some setting preventing that.
Do you have Clear History on Shutdown enabled and have long browsing sessions?