Closed Bug 1438790 Opened 4 years ago Closed 4 years ago

Figure out if generatesnippet.py is still useful

Categories

(Localization Infrastructure and Tools :: Automation, enhancement)

Product:
Localization Infrastructure and Tools
Component:
Automation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

Attachments

(1 file)

Bug 1438790 - Remove dead code generatesnippet.py
59 bytes, text/x-review-board-request
Callek
: review+
Details 
No actual change since 2010
Only called from toolkit/locales/l10n.mk / generate-snippet-% which doesn't seem to be called in-tree by anything else. The makefile didn't have any relevant changes since 2009.

I guess this is dead code.
Comment on attachment 8951543 [details]
Bug 1438790 - Remove dead code generatesnippet.py

https://reviewboard.mozilla.org/r/220854/#review226768

I think someone from releng would be a better reviewer. coop's been reviewing patches on this stuff before, maybe Callek.
Attachment #8951543 - Flags: review?(l10n)
Attachment #8951543 - Flags: review?(bugspam.Callek)
Comment on attachment 8951543 [details]
Bug 1438790 - Remove dead code generatesnippet.py

https://reviewboard.mozilla.org/r/220854/#review229430

This certainly looks dead to me
Attachment #8951543 - Flags: review?(bugspam.Callek) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ff022a3d2b7
Remove dead code generatesnippet.py r=Callek
https://hg.mozilla.org/mozilla-central/rev/1ff022a3d2b7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.