Closed
Bug 1438806
Opened 6 years ago
Closed 6 years ago
Popup permission has incorrect menulist value in the identity popup when popups were blocked
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox58 | --- | unaffected |
| firefox59 | --- | unaffected |
| firefox60 | --- | verified |
People
(Reporter: johannh, Assigned: johannh)
References
Details
(Keywords: regression)
Attachments
(1 file)
When a popup is blocked, the menulist in the identity block has "Allow" as its default value, while it should be "Block" (thanks Prathiksha for finding that).
Flags: qe-verify+
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951552 [details] Bug 1438806 - Set correct default permission when showing blocked popups in the identity popup. https://reviewboard.mozilla.org/r/220870/#review227054 Looks good to me.
Attachment #8951552 -
Flags: review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e38073a64f0b Set correct default permission when showing blocked popups in the identity popup. r=prathiksha
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e38073a64f0b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
status-firefox58:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Managed to reproduce the issue using Nightly 60.0a1 (2018-02-15) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12 using the http://www.popuptest.com/popuptest1.html link. Verified fixed using the latest Nightly 60.0a1(2018-02-22)on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
You need to log in
before you can comment on or make changes to this bug.
Description
•