1438843 - Add a linting rule to inform developers that they should not push changes in servo / nss or nspr from m-c

Status: NEW

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

In review phase, we should at least show a warning when someone is trying to touch servo, nspr or nss in m-c.

This happened here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1234008#c33

Comment 1

[Andrew Halberstadt [:ahal]]

This is a good idea! Two thoughts:

1) We could only run this linter when using --outgoing/--workdir, which mozlint doesn't support. I think the best approach here would be for the linter to live in the reviewbot github repo and we add it to the 'lint' path before running.

2) For the local case, it might be better to use a commit hook that gets set up via |mach bootstrap|. Of course we can't force people to use the commit hook, but if they opt not to use it, then they'll at least hit the server side hook. This commit hook could also use the proposed THIRD_PARTY_PATHS moz.build variables.

If we implement 2) it may not be worth doing 1), though might still be worth it. In either case we'll need a way to allow updating third party modules. I think servo uses a token in the commit message, maybe this approach could be generalized.