1438848 - 2 box-shadow tests fails to pass on new windows 10 hardware

Status: NEW

(Core :: Layout, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

we are getting new hardware to run windows 10 tests on and the tests are failing.

here are the fuzzy-if statements I used to get the tests to pass:
-fuzzy-if(OSX==1010,1,24) fuzzy-if(d2d,16,908) fuzzy-if(webrender,47-47,1080-1080) == boxshadow-large-border-radius.html boxshadow-large-border-radius-ref.html # Bug 12+fuzzy-if(OSX==1010,1,24) fuzzy-if(d2d,16,999) fuzzy-if(webrender,47-47,1080-1080) == boxshadow-large-border-radius.html boxshadow-large-border-radius-ref.html # Bug 12

-fuzzy-if(skiaContent,13,28) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-ref.svg
+fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu),98,152) fuzzy-if(skiaContent,32,27) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-r

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add fuzzy-if to get reftests green

Comment 2

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8951602 [details] [diff] [review]
add fuzzy-if to get reftests green

I would like to fuzzy-if and leave this open until there are dev cycles to look into this

Comment 4

[Geoff Brown [:gbrown]]

Comment on attachment 8951602 [details] [diff] [review]
add fuzzy-if to get reftests green

Review of attachment 8951602 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/box-shadow/reftest.list
@@ +15,3 @@
>  
>  fails-if(Android) == boxshadow-fileupload.html boxshadow-fileupload-ref.html
> +fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu),98,152) fuzzy-if(skiaContent,32,27) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-ref.svg

What happened here? There's both a new Windows 10 fuzzy-if and a modification of the existing skiaContent clause -- seems wrong.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add fuzzy-if to get reftests green

thanks for the feedback, lets try round two

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/391e4460758f
2 box-shadow tests fails to pass on new windows 10 hardware. r=gbrown

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b808fbc1b439
fix accidental change for webrender fuzzy-if in box-shadow test. r=me, a=test-only

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/391e4460758f
https://hg.mozilla.org/mozilla-central/rev/b808fbc1b439

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?