Open Bug 1438848 Opened 4 years ago Updated 2 years ago

2 box-shadow tests fails to pass on new windows 10 hardware

Categories

(Core :: Layout, defect, P3)

54 Branch
defect

Tracking

()

People

(Reporter: jmaher, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

we are getting new hardware to run windows 10 tests on and the tests are failing.

here are the fuzzy-if statements I used to get the tests to pass:
-fuzzy-if(OSX==1010,1,24) fuzzy-if(d2d,16,908) fuzzy-if(webrender,47-47,1080-1080) == boxshadow-large-border-radius.html boxshadow-large-border-radius-ref.html # Bug 12+fuzzy-if(OSX==1010,1,24) fuzzy-if(d2d,16,999) fuzzy-if(webrender,47-47,1080-1080) == boxshadow-large-border-radius.html boxshadow-large-border-radius-ref.html # Bug 12

-fuzzy-if(skiaContent,13,28) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-ref.svg
+fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu),98,152) fuzzy-if(skiaContent,32,27) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-r
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Comment on attachment 8951602 [details] [diff] [review]
add fuzzy-if to get reftests green

I would like to fuzzy-if and leave this open until there are dev cycles to look into this
Attachment #8951602 - Flags: review?(gbrown)
Comment on attachment 8951602 [details] [diff] [review]
add fuzzy-if to get reftests green

Review of attachment 8951602 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/box-shadow/reftest.list
@@ +15,3 @@
>  
>  fails-if(Android) == boxshadow-fileupload.html boxshadow-fileupload-ref.html
> +fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu),98,152) fuzzy-if(skiaContent,32,27) fuzzy-if(webrender,25,48) == boxshadow-inner-basic.html boxshadow-inner-basic-ref.svg

What happened here? There's both a new Windows 10 fuzzy-if and a modification of the existing skiaContent clause -- seems wrong.
Attachment #8951602 - Flags: review?(gbrown) → review-
thanks for the feedback, lets try round two
Attachment #8951602 - Attachment is obsolete: true
Attachment #8953388 - Flags: review?(gbrown)
Attachment #8953388 - Flags: review?(gbrown) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/391e4460758f
2 box-shadow tests fails to pass on new windows 10 hardware. r=gbrown
Keywords: leave-open
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b808fbc1b439
fix accidental change for webrender fuzzy-if in box-shadow test. r=me, a=test-only
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Blocks: 1627386
Flags: needinfo?(svoisen)
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.