1438850 - The Top Site image, title and pin icon are no longer displayed when it is dragged to a new position

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: drag preview image is the fallback letter.gif

[Affected versions]:
- Nightly 60.0a1

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser with a new profile.
2. Drag on of the Top Sites to a new position and observe its preview.

[Expected results]:
- The Top Site image, title and pin icon are displayed in the new position.

[Actual results]:
- The Top Site fallback image is displayed and there is no title or pin icon.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I forgot to mention that this behavior has been regressed by bug 1426705.

Comment 2

[Ed Lee :Mardak]

This change was by requested bby design in https://github.com/mozilla/activity-stream/pull/3976 with a followup https://github.com/mozilla/activity-stream/pull/3981 to correctly hide the letter so that it's only a gray box.

Comment 3

[Ed Lee :Mardak]

(The fix for hiding the letter will be exported as part of bug 1438821.)

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Could we also have some bugzilla bugs filed when these kind of changes happen? It's not always entirely obvious what's an intended change.

Comment 5

[Ed Lee :Mardak]

(In reply to Ciprian Muresan [:cmuresan], Desktop Engineering QA, :steve from comment #4)
> Could we also have some bugzilla bugs filed when these kind of changes
> happen? It's not always entirely obvious what's an intended change.
Nod. r1cky?

Comment 6

[Ed Lee :Mardak]

We brought this up in our retrospective. We'll try to get these filed especially for user-facing / QA-able stuff.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ed Lee :Mardak from comment #5)
> (In reply to Ciprian Muresan [:cmuresan], Desktop Engineering QA, :steve
> from comment #4)
> > Could we also have some bugzilla bugs filed when these kind of changes
> > happen? It's not always entirely obvious what's an intended change.
> Nod. r1cky?

yep! We aren't a little experiment anymore so user facing changes need to be tracked and communicated. My bad!