Open Bug 1438851 Opened 2 years ago Updated 4 months ago

10 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware

Categories

(Core :: Layout, enhancement, P3)

54 Branch
enhancement

Tracking

()

People

(Reporter: jmaher, Unassigned, NeedInfo)

References

Details

(Keywords: leave-open)

Attachments

(1 file, 2 obsolete files)

you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

we are getting new hardware to run windows 10 tests on and the tests are failing.
456219-1a.html
456219-1b.html
456219-1c.html
718521.html
991046-1.html
1116480-1-fakeitalic-overflow.html
1316719-1a.html
1316719-1b.html
1316719-1c.html
found one more in a recent test:
1425243-2.html

https://treeherder.mozilla.org/#/jobs?repo=try&revision=331f5dc8e73abae7ba5af373c359d8f9ddd52d9a
Summary: 9 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware → 10 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Attachment #8951609 - Attachment is obsolete: true
Comment on attachment 8952404 [details] [diff] [review]
add fuzzy-if to get reftests green

I would like to fuzzy-if and leave this open until there are dev cycles to look into this
Attachment #8952404 - Flags: review?(gbrown)
Comment on attachment 8952404 [details] [diff] [review]
add fuzzy-if to get reftests green

Review of attachment 8952404 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/reftest.list
@@ +1992,5 @@
>  fuzzy(2,20000) == 1315113-2.html 1315113-2-ref.html
>  == 1315632-1.html 1315632-1-ref.html
> +fuzzy(13,40000) fails-if(webrender) == 1316719-1a.html 1316719-1-ref.html
> +fuzzy(13,40000) fails-if(webrender) == 1316719-1b.html 1316719-1-ref.html
> +fuzzy(13,40000) == 1316719-1c.html 1316719-1-ref.html

I'm a little uneasy about expanding the fuzzy scope that much...but who knows if it is important? Consider adding a Windows 10-specific fuzzy-if instead.
Attachment #8952404 - Flags: review?(gbrown) → review+
updated patch with review suggestions.
Attachment #8952404 - Attachment is obsolete: true
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bba8187c791f
9 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware. r=gbrown
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
You need to log in before you can comment on or make changes to this bug.