Open
Bug 1438851
Opened 8 years ago
Updated 1 year ago
10 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware
Categories
(Core :: Layout, defect, P3)
Tracking
()
NEW
People
(Reporter: jmaher, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
7.16 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest
we are getting new hardware to run windows 10 tests on and the tests are failing.
| Reporter | ||
Comment 1•8 years ago
|
||
456219-1a.html
456219-1b.html
456219-1c.html
718521.html
991046-1.html
1116480-1-fakeitalic-overflow.html
1316719-1a.html
1316719-1b.html
1316719-1c.html
| Reporter | ||
Comment 2•8 years ago
|
||
found one more in a recent test:
1425243-2.html
https://treeherder.mozilla.org/#/jobs?repo=try&revision=331f5dc8e73abae7ba5af373c359d8f9ddd52d9a
Summary: 9 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware → 10 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware
| Reporter | ||
Comment 3•8 years ago
|
||
| Reporter | ||
Updated•8 years ago
|
Attachment #8951609 -
Attachment is obsolete: true
| Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8952404 [details] [diff] [review]
add fuzzy-if to get reftests green
I would like to fuzzy-if and leave this open until there are dev cycles to look into this
Attachment #8952404 -
Flags: review?(gbrown)
Comment 6•8 years ago
|
||
Comment on attachment 8952404 [details] [diff] [review]
add fuzzy-if to get reftests green
Review of attachment 8952404 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/reftests/bugs/reftest.list
@@ +1992,5 @@
> fuzzy(2,20000) == 1315113-2.html 1315113-2-ref.html
> == 1315632-1.html 1315632-1-ref.html
> +fuzzy(13,40000) fails-if(webrender) == 1316719-1a.html 1316719-1-ref.html
> +fuzzy(13,40000) fails-if(webrender) == 1316719-1b.html 1316719-1-ref.html
> +fuzzy(13,40000) == 1316719-1c.html 1316719-1-ref.html
I'm a little uneasy about expanding the fuzzy scope that much...but who knows if it is important? Consider adding a Windows 10-specific fuzzy-if instead.
Attachment #8952404 -
Flags: review?(gbrown) → review+
| Reporter | ||
Comment 7•8 years ago
|
||
updated patch with review suggestions.
Attachment #8952404 -
Attachment is obsolete: true
| Reporter | ||
Updated•8 years ago
|
Attachment #8953387 -
Flags: review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bba8187c791f
9 tests in layout/reftests/bugs/ fail to pass on new windows 10 hardware. r=gbrown
| Reporter | ||
Updated•8 years ago
|
Keywords: leave-open
Comment 9•8 years ago
|
||
| bugherder | ||
Comment 10•7 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Comment 11•7 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Comment 12•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Updated•6 years ago
|
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•