1438930 - Update Debugger Frontend v17

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Jason Laster [:jlast]]

Attachment: rel-17.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=913f8918885ea62f905d5d7a74a9eab08781e436

https://github.com/devtools-html/debugger.html/compare/release-16...release-17
it's a lot of small commits

Comment 3

[Jason Laster [:jlast]]

Attachment: rel-17-3.patch

Comment 4

[Jason Laster [:jlast]]

a new try run

https://treeherder.mozilla.org/#/jobs?repo=try&revision=340fa09dc0e3294cd38268d79d9fa144139c240d

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8951699 [details] [diff] [review]
rel-17-3.patch

Review of attachment 8951699 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/locales/en-US/debugger.properties
@@ +47,5 @@
>  # LOCALIZATION NOTE (expandPanes): This is the tooltip for the button
>  # that expands the left and right panes in the debugger UI.
>  expandPanes=Expand panes
>  
> +# LOCALIZATION NOTE (evaluateInConsole): Editor right-click menu item

Still wrong, should be evaluateInConsole.label

Comment 6

[Jason Laster [:jlast]]

yep, waiting on try for a new patch

Comment 7

[Jason Laster [:jlast]]

Attachment: rel-17-4.patch

Comment 8

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6c52383667f8f20f23a155680a9ba48f4258ac9&selectedJob=163091730

Comment 9

[Jason Laster [:jlast]]

Attachment: rel-17-5.patch

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8952254 [details] [diff] [review]
rel-17-5.patch

Review of attachment 8952254 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: done
 - commit message: OK
 - less than 20 commits: KO. 
   40 commits, are we no longer trying to keep the commit count reasonable?
- TRY
 - try run green: OK
 - try run has rebuild: ok (rebuild 3 instead of 4 here? reason?)
- Manual test
 - OK
- README review
 - compare link: OK
 - version number: OK
- Properties file review: OK
- New files: OK

Can't push to talos at the moment since try is closed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/189364f02193
Update Debugger Frontend v17. r=jdescottes

Comment 12

[Julian Descottes [:jdescottes]]

talos shows some improvement: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=311e01be916de42ea9f1e2c2ad991ec8a14309b8&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyImportant=1&framework=1&selectedTimeRange=172800

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/189364f02193

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Bug 1439839 documents the installer size regression from this change; if we don't resolve it, we may need to back this out.

Comment 15

[Jason Laster [:jlast]]

Hi :milan, i'm working on a fix for 1439839. I'll hopefully have something in the next couple of days.

Comment 16

[Jason Laster [:jlast]]

Milan, here is a link to the PR which is the works - https://github.com/devtools-html/debugger.html/pull/5557

It brings the bundle down from 1.7 to 1.0mb again. We'll have a follow up PR to bring it to 750kb afterwards. This should be fixed in the next couple of days.